GH-1429 Add WebSockets and bump mininum version numbers #234
Conversation
|
ws, wss settings in background.js should be gated from Edge |
|
Fixed by not listening to WebSockets on Edge. @zarembsky please review again. |
|
Looks good. |
jsignanini
added a commit
that referenced
this pull request
Nov 15, 2018
jsignanini
added a commit
that referenced
this pull request
Nov 19, 2018
jsignanini
added a commit
that referenced
this pull request
Nov 20, 2018
jsignanini
added a commit
that referenced
this pull request
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Added WebSockets bug checking for WebSockets!
Bumped minimum browser versions for websocket support.
Need to test this heavily on Edge.