Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated summary view. #25

Merged
merged 15 commits into from Apr 4, 2018
Merged

Conversation

@IAmThePan
Copy link
Contributor

@IAmThePan IAmThePan commented Apr 3, 2018

GH-863 Moved pause button next to trust/restrict. Remove custom settings.
GH-876 Moved the Simple/Detailed View toggle to tabs in the header.
GH-888 Update tooltips and notification for Trust/Restrict/Pause.
GH-867 Create an alternate Simple View with the Pause button in the top left.
GH-862 Created unit tests for PauseButton.jsx

@christophertino Please approve

@IAmThePan IAmThePan requested review from trickpattyFH20 and ghostery/ghostery as code owners Apr 3, 2018
Copy link
Member

@jsignanini jsignanini left a comment

@IAmThePan I'm getting an error on the panel's background page that's preventing it from rendering at all, please take a look.

@IAmThePan IAmThePan force-pushed the IAmThePan:simple-view-merge branch from 7beca00 to ab78614 Apr 4, 2018
Copy link
Member

@jsignanini jsignanini left a comment

@IAmThePan looks good. Please run npm run docs and fix those few errors there. It should be fine then.

@jsignanini jsignanini merged commit b9cdcd3 into ghostery:develop Apr 4, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@IAmThePan IAmThePan deleted the IAmThePan:simple-view-merge branch Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants