Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade webpack and fix watch scss bug #26

Merged
merged 2 commits into from Apr 4, 2018

Conversation

@trickpattyFH20
Copy link
Contributor

@trickpattyFH20 trickpattyFH20 commented Apr 3, 2018

No description provided.

@trickpattyFH20 trickpattyFH20 requested a review from jsignanini Apr 3, 2018
@trickpattyFH20 trickpattyFH20 requested a review from ghostery/ghostery as a code owner Apr 3, 2018
Copy link
Member

@jsignanini jsignanini left a comment

@trickpattyFH20 please fix the .scss files getting sent through the eslint command when watching. See the accidentally removed check on 523cbcb

@trickpattyFH20
Copy link
Contributor Author

@trickpattyFH20 trickpattyFH20 commented Apr 3, 2018

lint watching scss files is fixed 👍 @jsignanini

@jsignanini jsignanini merged commit 03a6be5 into ghostery:develop Apr 4, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants