Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panel Bug Fixes #28

Merged
merged 6 commits into from Apr 9, 2018
Merged

Panel Bug Fixes #28

merged 6 commits into from Apr 9, 2018

Conversation

@IAmThePan
Copy link
Contributor

@IAmThePan IAmThePan commented Apr 6, 2018

GH-911: Bug Fixes for Edge

  • Eliminate the Scroll bar
  • Fix the 1px pause button bug
  • Pause button caret doesn't work fix
  • Fix Inline SVGs
IAmThePan added 3 commits Apr 6, 2018
@IAmThePan
Panel Fixes: Fix CSS SVG encoding for FF
9697aae
@IAmThePan
Panel Fixes: HTML encode inline SVGs
58e8816
@IAmThePan
Panel Fixes: Edge bug fixes (GH-911)
Loading status checks…
bf28571
@IAmThePan IAmThePan requested a review from ghostery/ghostery as a code owner Apr 6, 2018
@IAmThePan
GH-867 Alternate Summary View AB Test
08fc2da
@jsignanini
jsignanini requested changes Apr 9, 2018
View changes
Copy link
Member

@jsignanini jsignanini left a comment

@IAmThePan I am seeing full panel vertical and horizontal scrollbars appear in the panel when they shouldn't on Firefox, can you please take a look?
IAmThePan added 2 commits Apr 9, 2018
@IAmThePan
Fix overflow scroll issue
0266a29
@IAmThePan
Toggle Summary AB test off
Loading status checks…
d30db63
@jsignanini
jsignanini approved these changes Apr 9, 2018
View changes
@jsignanini jsignanini merged commit 99d9bec into ghostery:develop Apr 9, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignanini jsignanini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@IAmThePan @jsignanini