Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghostery changes for Offers support #30

Closed
wants to merge 8 commits into from

Conversation

@zarembsky
Copy link
Contributor

@zarembsky zarembsky commented Apr 9, 2018

  • [x ] Have you followed the guidelines in CONTRIBUTING.md?
  • [x ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [x ] Have you added an explanation of what your changes do?
  • [x ] Does your submission pass tests?
  • [x ] Did you lint your code prior to submission?
@zarembsky zarembsky requested a review from ghostery/ghostery as a code owner Apr 9, 2018
@zarembsky zarembsky requested a review from agustin-cliqz Apr 9, 2018
Serge Zarembsky
Copy link

@agustin-cliqz agustin-cliqz left a comment

Hi Serge, looks good, regarding the CliqzEvents interface (to subscribe to events), lets ask @chrmod if he thinks there will be any problems with it (I can implement the interface should be trivial)

@christophertino christophertino requested a review from chrmod Apr 10, 2018
@zarembsky zarembsky closed this Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants