Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-862: Unit tests for the Panel #31

Merged
merged 3 commits into from Apr 12, 2018
Merged

GH-862: Unit tests for the Panel #31

merged 3 commits into from Apr 12, 2018

Conversation

@IAmThePan
Copy link
Contributor

@IAmThePan IAmThePan commented Apr 9, 2018

Unit tests for the panel:

  • Snapshot testing for PauseButton.jsx (These already existed on develop, but haven't been reviewed yet. I renamed the tests)
  • Unit tests using Jest for SummaryActions
  • Unit tests using Jest for reducer: summary.js

(There is also a one-line tooltip fix included in this because it was on my develop branch)
@christophertino please approve
@IAmThePan IAmThePan requested a review from ghostery/ghostery as a code owner Apr 9, 2018
@IAmThePan
GH-862 Add unit tests for the Panel: Pause Button Snapshot, Summary A…
Loading status checks…
75c2c86 
…ctions & Reducers
@IAmThePan IAmThePan force-pushed the IAmThePan:unit-tests branch from 2331f6f to 75c2c86 Apr 10, 2018
@IAmThePan
Update reducers to test for immutable state
Loading status checks…
7a6b984
@christophertino
christophertino approved these changes Apr 12, 2018
View changes
@christophertino
Merge branch 'develop' into unit-tests
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
3b4d25c
@christophertino christophertino merged commit 48b74b0 into ghostery:develop Apr 12, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@IAmThePan IAmThePan deleted the IAmThePan:unit-tests branch Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@IAmThePan @christophertino