Feature/gh 1517 dynamic ui rendering #343
Closed
Conversation
…y the updates relevant to the Panel and Summary UIs
… case without duplication
…rinch branch up to date with current develop state
…ring feature branch up to date with develop
|
1 through 5 have all been addressed |
…stery/ghostery-extension into feature/GH-1517_dynamic-UI-rendering
…stery/ghostery-extension into feature/GH-1517_dynamic-UI-rendering
|
looks good. |
|
Looks good. |
…TA so as not to break AccountReducer, which relies on that name
|
Closing in favor of #355 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Implements dynamic updating of the extension panel UI including the Summary and Detailed views. This includes dynamic updating of the various tracker counts as the page loads, dynamic insertion of trackers into the blocking list as they are found, and dynamic redrawing of the donut graph.
Streamlines all UI data transfer between the panel (including its Panel, Summary, Blocking, Settings, and Rewards components) and the background to use ports managed by PanelData, obviating all such transfer through message passing.
Factors out Cliqz antitracking and adblocking modules data retrieval into a utility file that both BrowserButton and PanelData can use, reducing duplication across BrowserButton and PanelData & the GET_CLIQZ_MODULE_DATA reducer on the front end.
Refactors FoundBugs to more efficiently handle the now potentially much larger volume of requests for bug info, primarily by storing foundApps data alongside foundBugs data so it does not need to be repeatedly recalculated.
Refactors and simplifies PanelData.