New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/gh 1517 dynamic ui rendering #343
Closed
+1,515
−1,250
Revert the remainder of performance measurement changes
4e24b96
Select commit
88fc5e4
Convert PanelData export to a singleton to facilitate dynamic UI port…
wlycdgr 51b2a00
Add summaryUIPort
wlycdgr 2516435
Move summaryUIPort to panel data. Create port initializion function
wlycdgr b1996fe
Add PanelData#updatePanelUI stub. Add call to this stub from eventsHa…
wlycdgr 945245e
Create a map on panelData to store our multiple UI ports
wlycdgr a780efc
Reorder port connect name checks to account for relative frequency
wlycdgr 3d14b93
Constantize summary ui port name
wlycdgr adb5b45
Update summary ui port name constant name
wlycdgr fe19632
Disconnect summary UI port on component unmount
wlycdgr 705ae1c
Simplify logging to use existing utils api. revert port constant name
wlycdgr 3c64875
post message to Summary component on bug update
wlycdgr 87959b0
Add TODOs. Comment out code for testing.
wlycdgr b7708c1
Make tracker donut dynamic
wlycdgr 96b4a72
Debug UI port flow and make sure the right tab objects are being pass…
wlycdgr d456d0c
Define PanelData#updatePanelAndSummaryTrackerData, which performs onl…
wlycdgr db70769
Refactor tracker data building in Panel Data to accomodate update use…
wlycdgr 504bedf
Merge branch 'develop' into feature/GH-1517_dynamic-UI-rendering to …
wlycdgr 50be4ff
Revise PanelData updates to placate linter
wlycdgr de84196
Update variable names in PanelData and remove some testing code
wlycdgr 768f142
Add data structure doc for per-tab apps memoization to FoundBugs
wlycdgr b3b0f5c
Refactor FoundBugs to speed up app retrieval
wlycdgr 4ab94a4
Fix typo in FoundBugs
wlycdgr f2d5751
Fix typo and uncomment a necessary line
wlycdgr 0110050
Debugging hasLatencyIssue bug
wlycdgr 9c2c7a4
Merge branch 'develop' into feature/GH-1517_dynamic-UI-rendering to b…
wlycdgr b539fcf
Fix assignment bug in hasLatencyIssue and remove debugging statements
wlycdgr 86d3643
Clean up UI port listener in the Panel component
wlycdgr bd0d306
Move summary ui port back to Summary component
wlycdgr 298d78b
Work on updating PanelData to handle update requests efficiently
wlycdgr a240322
Continue PanelData refactor
wlycdgr cbaa7ee
Retrieve active tab on port init and store in PanelData to avoid retr…
wlycdgr 149e84d
Continue to refactor PanelData
wlycdgr 27e0593
Work in progress on PanelData
wlycdgr 0faa19a
Continue refactor of PanelData
wlycdgr 786b778
Send init data on first time panel opens port on a tab
wlycdgr 6fd1513
Use dynamic UI ports to retrieve initial panel data as well
wlycdgr 4b9e7f1
Remove unnecessary functions from PanelData
wlycdgr 8f359bd
Remove linear regression import from PanelData...not sure how it ende…
wlycdgr edb8d69
Remove now-redundant panelView getter and object on PanelData
wlycdgr afabd8e
Remove dependence on building tracker data map in PanelData
wlycdgr 1f46583
Remove tracker data map from PanelData
wlycdgr bdee64c
Linter placation fixes in PanelData
wlycdgr 79b49b6
Delete private *View var that are only ever used to return from their…
wlycdgr f51026a
Work to remove redundant confData data structure in PanelData
wlycdgr 69478c7
Fix subscriptionsPlus typo
wlycdgr 185e2bd
Delete this._confData get from this._buildCategories in PanelData
wlycdgr 0ce4200
Remove this._buildConfData() from PanelData
wlycdgr 5e0a907
Move updateSummaryData to SummaryActions
wlycdgr 98dde48
Add blocking UI port. Move retrieval of blocking data to this port.
wlycdgr 5ebb380
Activate blockingUIPort
wlycdgr 154baf5
Clean up unnecessary code and comments
wlycdgr 7d139ad
Convert Settings component to use port to get initial settings data
wlycdgr 67367fb
Remove unnecessary call in Settings
wlycdgr 6d505c3
Remove this._buildConfData call in PanelData#set
wlycdgr b232349
Update account.getUserSettings error message to reflect that it now l…
wlycdgr 3516412
Remove log statements from Panel and Summary render funcs
wlycdgr 9968d2a
Move rewards panel port to PanelData. Modify front and back end code …
wlycdgr a3fd2d0
Implement passing rewards panel data through PanelData port
wlycdgr b4bc375
Remove obviated Rewards panel background data retrieval code
wlycdgr 287c034
Remove obviated PanelData#get
wlycdgr 1bc265c
Clean up PanelData#initUIPort
wlycdgr 051435d
Remove outdated PanelData constructor comment
wlycdgr efda3dd
Add comments to PanelData
wlycdgr bde6e1b
Remove variable related to removed PanelData conf Map from PanelData#set
wlycdgr ff16c6d
Minor change to reduce duplication in PanelData#set
wlycdgr d29e5dc
Factor some duplicate code in PanelData#set out to a helper func
wlycdgr aab593b
Remove commented out code from PanelData#set
wlycdgr 4fcc7e1
Work towards converting getCliqzModuleData to use the summary UI port…
wlycdgr 1571067
Modify GET_CLIQZ_MODULE_DATA reducer to look for 'blocked' rather tha…
wlycdgr 84e7a57
Remove code that was used to get cliqz module data via messages, sinc…
wlycdgr 4b689bb
Update BrowserButton#_getAntiTrackCount to check for 'blocked' rather…
wlycdgr 1409296
Move cliqz antitracking and adblocking data retrieval to utils functi…
wlycdgr e9aa8e3
Remove unnecessary imports from BrowserButton. Linter clean up.
wlycdgr baddd40
Convert PanelData to use the cliqzModuleData utility functions
wlycdgr d30c723
Remove redundant unsafe count calculation from GET_CLIQZ_MODULE_DATA …
wlycdgr f168850
Revert to 'unsafe' in cliqModuleData and remove some logging calls
wlycdgr e67eb83
Update GET_REWARDS_DATA test
wlycdgr b900205
Update GET_CLIQZ_MODULE_DATA reducer and action creator tests
wlycdgr df0b2fb
Make donut arc a property on DonutGraph
wlycdgr 09f9171
Make trackerPie a property on DonutGraph
wlycdgr 4d5c8f6
Move towards correct updating of donut graph, without adding new elem…
wlycdgr b4a5633
Implement donut updating without adding new SVG elements
wlycdgr 69eeb21
Begin adding UI state to Blocking to preserve per category expansion …
wlycdgr 968d1e2
Always send blocking data on opening of blocking port instead of only…
wlycdgr 1198e8a
Reduce duplicdation in data retrieval functions in PanelData. Streaml…
wlycdgr c95447d
Make sure rewards UI port disconnects. Handle detaching disconnect li…
wlycdgr 209bda4
Reset page load time display if page is reloaded while panel is open
wlycdgr af2e4ba
Ensure that page load data is sent even if panel is first opened afte…
wlycdgr 3c4f4d6
Work towards finalizing the API, organization, and documentation of P…
wlycdgr c3433ac
Continue finalizing refactor of PanelData
wlycdgr 8baf15a
Finish PanelData refactor and reorganization. Fix typo in FoundBugs
wlycdgr db0e44b
Fix bug in summary data retrieval
wlycdgr 0facec1
Add TODO comment to RewardsActions. Modify ui port code to make sure …
wlycdgr 00ee717
Remove extraneous param listing from FoundBugs#update comment
wlycdgr 6c9416c
Remove commented out code block and unused import from foundbugs.test.js
wlycdgr a85bcc8
Fix minor typos in foundbugs.test.js
wlycdgr 0926253
Remove some debug logging from Rewards component. Update Rewards comp…
wlycdgr 3d61faf
Remove unnecessary sinon import from Rewards test file
wlycdgr 02a890a
Fix FoundBugs bug that kept any bugs from being blocked: true
wlycdgr 24b2d74
Clean up Blocking#render in process of implementing expand/collapse t…
wlycdgr b89c383
Fix function call typo in PanelData
wlycdgr 7052a98
Make sure extension loads correctly if there is no needsReload value …
wlycdgr 136a469
Implement per category expanded state preservation during loading in …
wlycdgr 0058677
Debug and cleanup expand/contract per category state preservation dur…
wlycdgr 3cb5167
Throttle DonutGraph#_bakeDonut
wlycdgr f49761f
Remove unnecessary totalCount parameter extraction & passing from Don…
wlycdgr 2b67b20
Restore immediate updating to redscale/greyscale in response to user …
wlycdgr 970ae9f
Animate donut graph reslicing. Delint code.
wlycdgr fa98388
Add padAngle TODO note to DonutGraph. Remove commented out code.
wlycdgr 6d32923
Merge branch 'develop' into feature/GH-1517_dynamic-UI-rendering
IAmThePan 09dac12
Merge in new browser-core build from develop
wlycdgr 7e8a130
Clean up merge comments from package.json
wlycdgr bd265d0
Merge branch 'feature/GH-1517_dynamic-UI-rendering' of github.com:gho…
wlycdgr c72c5db
Update yarn.lock
IAmThePan f1bef8d
Merge branch 'feature/GH-1517_dynamic-UI-rendering' of github.com:gho…
IAmThePan 2503fa0
Merge branch 'develop' into feature/GH-1517_dynamic-UI-rendering
jsignanini acded00
Rearrange function calls in Panel#componentDidMount
wlycdgr 1b61c2c
Change type of action created by updatePanelData back to GET_PANEL_DA…
wlycdgr 045bb6c
Merge branch 'develop' into feature/GH-1517_dynamic-UI-rendering
wlycdgr 773dafe
Remove a removeListener call that should not have been there from pan…
wlycdgr 4fd878e
Modify rewards ui port code & logic to match current behavior
wlycdgr b8f36db
Throttle PanelData#updatePanelUI to 600ms, matching the donut redraw …
wlycdgr 27b202b
Add and modify panel UI update throttling comments
wlycdgr 96da132
Send account data with panel updates to avoid account reducer error
wlycdgr 4869f71
Add performance analysis code
wlycdgr eeb926c
Add panel open performance logging
wlycdgr 4127122
Remove performance logging
wlycdgr 8df86d9
Remove performance analysis code
wlycdgr 4e24b96
Revert the remainder of performance measurement changes
wlycdgr
Closed
Feature/gh 1517 dynamic ui rendering #343
Revert the remainder of performance measurement changes
Jan 30, 2019
Jan 30, 2019
Jan 31, 2019
Jan 31, 2019
Feb 1, 2019
Feb 1, 2019
Feb 1, 2019
Feb 1, 2019
Feb 1, 2019
Feb 1, 2019
Feb 1, 2019
Feb 4, 2019
Feb 5, 2019
Feb 6, 2019
Feb 6, 2019
Feb 7, 2019
Feb 7, 2019
Feb 7, 2019
Feb 7, 2019
Feb 8, 2019
Feb 11, 2019
Feb 11, 2019
Feb 11, 2019
Feb 12, 2019
Feb 12, 2019
Feb 12, 2019
Feb 12, 2019
Feb 13, 2019
Feb 13, 2019
Feb 13, 2019
Feb 13, 2019
Feb 13, 2019
Feb 13, 2019
Feb 13, 2019
Feb 14, 2019
Feb 14, 2019
Feb 14, 2019
Feb 14, 2019
Feb 14, 2019
Feb 14, 2019
Feb 14, 2019
Feb 14, 2019
Feb 14, 2019
Feb 15, 2019
Feb 15, 2019
Feb 15, 2019
Feb 15, 2019
Feb 15, 2019
Feb 15, 2019
Feb 15, 2019
Feb 15, 2019
Feb 15, 2019
Feb 15, 2019
Feb 15, 2019
Feb 15, 2019
Feb 15, 2019
Feb 15, 2019
Feb 15, 2019
Feb 15, 2019
Feb 15, 2019
Feb 15, 2019
Feb 15, 2019
Feb 15, 2019
Feb 15, 2019
Feb 16, 2019
Feb 16, 2019
Feb 16, 2019
Feb 16, 2019
Feb 18, 2019
Feb 18, 2019
Feb 19, 2019
Feb 19, 2019
Feb 19, 2019
Feb 19, 2019
Feb 19, 2019
Feb 19, 2019
Feb 19, 2019
Feb 19, 2019
Feb 19, 2019
Feb 19, 2019
Feb 20, 2019
Feb 20, 2019
Feb 20, 2019
Feb 20, 2019
Feb 20, 2019
Feb 20, 2019
Feb 21, 2019
Feb 21, 2019
Feb 25, 2019
Feb 26, 2019
Feb 26, 2019
Feb 26, 2019
Feb 26, 2019
Feb 26, 2019
Feb 26, 2019
Feb 26, 2019
Feb 26, 2019
Feb 26, 2019
Feb 26, 2019
Feb 26, 2019
Feb 26, 2019
Feb 27, 2019
Feb 27, 2019
Feb 27, 2019
Feb 28, 2019
Feb 28, 2019
Feb 28, 2019
Feb 28, 2019
Feb 28, 2019
Feb 28, 2019
Feb 28, 2019
Feb 28, 2019
Feb 28, 2019
Feb 28, 2019
Feb 28, 2019
Mar 4, 2019
Mar 4, 2019
Mar 4, 2019
Mar 5, 2019
Mar 5, 2019
Mar 5, 2019
Mar 7, 2019
Mar 7, 2019
Mar 11, 2019
Mar 12, 2019
Mar 12, 2019
Mar 12, 2019
Mar 12, 2019
Mar 12, 2019
4e24b96
Select commit
88fc5e4
Convert PanelData export to a singleton to facilitate dynamic UI port…
wlycdgr 51b2a00
Add summaryUIPort
wlycdgr 2516435
Move summaryUIPort to panel data. Create port initializion function
wlycdgr b1996fe
Add PanelData#updatePanelUI stub. Add call to this stub from eventsHa…
wlycdgr 945245e
Create a map on panelData to store our multiple UI ports
wlycdgr a780efc
Reorder port connect name checks to account for relative frequency
wlycdgr 3d14b93
Constantize summary ui port name
wlycdgr adb5b45
Update summary ui port name constant name
wlycdgr fe19632
Disconnect summary UI port on component unmount
wlycdgr 705ae1c
Simplify logging to use existing utils api. revert port constant name
wlycdgr 3c64875
post message to Summary component on bug update
wlycdgr 87959b0
Add TODOs. Comment out code for testing.
wlycdgr b7708c1
Make tracker donut dynamic
wlycdgr 96b4a72
Debug UI port flow and make sure the right tab objects are being pass…
wlycdgr d456d0c
Define PanelData#updatePanelAndSummaryTrackerData, which performs onl…
wlycdgr db70769
Refactor tracker data building in Panel Data to accomodate update use…
wlycdgr 504bedf
Merge branch 'develop' into feature/GH-1517_dynamic-UI-rendering to …
wlycdgr 50be4ff
Revise PanelData updates to placate linter
wlycdgr de84196
Update variable names in PanelData and remove some testing code
wlycdgr 768f142
Add data structure doc for per-tab apps memoization to FoundBugs
wlycdgr b3b0f5c
Refactor FoundBugs to speed up app retrieval
wlycdgr 4ab94a4
Fix typo in FoundBugs
wlycdgr f2d5751
Fix typo and uncomment a necessary line
wlycdgr 0110050
Debugging hasLatencyIssue bug
wlycdgr 9c2c7a4
Merge branch 'develop' into feature/GH-1517_dynamic-UI-rendering to b…
wlycdgr b539fcf
Fix assignment bug in hasLatencyIssue and remove debugging statements
wlycdgr 86d3643
Clean up UI port listener in the Panel component
wlycdgr bd0d306
Move summary ui port back to Summary component
wlycdgr 298d78b
Work on updating PanelData to handle update requests efficiently
wlycdgr a240322
Continue PanelData refactor
wlycdgr cbaa7ee
Retrieve active tab on port init and store in PanelData to avoid retr…
wlycdgr 149e84d
Continue to refactor PanelData
wlycdgr 27e0593
Work in progress on PanelData
wlycdgr 0faa19a
Continue refactor of PanelData
wlycdgr 786b778
Send init data on first time panel opens port on a tab
wlycdgr 6fd1513
Use dynamic UI ports to retrieve initial panel data as well
wlycdgr 4b9e7f1
Remove unnecessary functions from PanelData
wlycdgr 8f359bd
Remove linear regression import from PanelData...not sure how it ende…
wlycdgr edb8d69
Remove now-redundant panelView getter and object on PanelData
wlycdgr afabd8e
Remove dependence on building tracker data map in PanelData
wlycdgr 1f46583
Remove tracker data map from PanelData
wlycdgr bdee64c
Linter placation fixes in PanelData
wlycdgr 79b49b6
Delete private *View var that are only ever used to return from their…
wlycdgr f51026a
Work to remove redundant confData data structure in PanelData
wlycdgr 69478c7
Fix subscriptionsPlus typo
wlycdgr 185e2bd
Delete this._confData get from this._buildCategories in PanelData
wlycdgr 0ce4200
Remove this._buildConfData() from PanelData
wlycdgr 5e0a907
Move updateSummaryData to SummaryActions
wlycdgr 98dde48
Add blocking UI port. Move retrieval of blocking data to this port.
wlycdgr 5ebb380
Activate blockingUIPort
wlycdgr 154baf5
Clean up unnecessary code and comments
wlycdgr 7d139ad
Convert Settings component to use port to get initial settings data
wlycdgr 67367fb
Remove unnecessary call in Settings
wlycdgr 6d505c3
Remove this._buildConfData call in PanelData#set
wlycdgr b232349
Update account.getUserSettings error message to reflect that it now l…
wlycdgr 3516412
Remove log statements from Panel and Summary render funcs
wlycdgr 9968d2a
Move rewards panel port to PanelData. Modify front and back end code …
wlycdgr a3fd2d0
Implement passing rewards panel data through PanelData port
wlycdgr b4bc375
Remove obviated Rewards panel background data retrieval code
wlycdgr 287c034
Remove obviated PanelData#get
wlycdgr 1bc265c
Clean up PanelData#initUIPort
wlycdgr 051435d
Remove outdated PanelData constructor comment
wlycdgr efda3dd
Add comments to PanelData
wlycdgr bde6e1b
Remove variable related to removed PanelData conf Map from PanelData#set
wlycdgr ff16c6d
Minor change to reduce duplication in PanelData#set
wlycdgr d29e5dc
Factor some duplicate code in PanelData#set out to a helper func
wlycdgr aab593b
Remove commented out code from PanelData#set
wlycdgr 4fcc7e1
Work towards converting getCliqzModuleData to use the summary UI port…
wlycdgr 1571067
Modify GET_CLIQZ_MODULE_DATA reducer to look for 'blocked' rather tha…
wlycdgr 84e7a57
Remove code that was used to get cliqz module data via messages, sinc…
wlycdgr 4b689bb
Update BrowserButton#_getAntiTrackCount to check for 'blocked' rather…
wlycdgr 1409296
Move cliqz antitracking and adblocking data retrieval to utils functi…
wlycdgr e9aa8e3
Remove unnecessary imports from BrowserButton. Linter clean up.
wlycdgr baddd40
Convert PanelData to use the cliqzModuleData utility functions
wlycdgr d30c723
Remove redundant unsafe count calculation from GET_CLIQZ_MODULE_DATA …
wlycdgr f168850
Revert to 'unsafe' in cliqModuleData and remove some logging calls
wlycdgr e67eb83
Update GET_REWARDS_DATA test
wlycdgr b900205
Update GET_CLIQZ_MODULE_DATA reducer and action creator tests
wlycdgr df0b2fb
Make donut arc a property on DonutGraph
wlycdgr 09f9171
Make trackerPie a property on DonutGraph
wlycdgr 4d5c8f6
Move towards correct updating of donut graph, without adding new elem…
wlycdgr b4a5633
Implement donut updating without adding new SVG elements
wlycdgr 69eeb21
Begin adding UI state to Blocking to preserve per category expansion …
wlycdgr 968d1e2
Always send blocking data on opening of blocking port instead of only…
wlycdgr 1198e8a
Reduce duplicdation in data retrieval functions in PanelData. Streaml…
wlycdgr c95447d
Make sure rewards UI port disconnects. Handle detaching disconnect li…
wlycdgr 209bda4
Reset page load time display if page is reloaded while panel is open
wlycdgr af2e4ba
Ensure that page load data is sent even if panel is first opened afte…
wlycdgr 3c4f4d6
Work towards finalizing the API, organization, and documentation of P…
wlycdgr c3433ac
Continue finalizing refactor of PanelData
wlycdgr 8baf15a
Finish PanelData refactor and reorganization. Fix typo in FoundBugs
wlycdgr db0e44b
Fix bug in summary data retrieval
wlycdgr 0facec1
Add TODO comment to RewardsActions. Modify ui port code to make sure …
wlycdgr 00ee717
Remove extraneous param listing from FoundBugs#update comment
wlycdgr 6c9416c
Remove commented out code block and unused import from foundbugs.test.js
wlycdgr a85bcc8
Fix minor typos in foundbugs.test.js
wlycdgr 0926253
Remove some debug logging from Rewards component. Update Rewards comp…
wlycdgr 3d61faf
Remove unnecessary sinon import from Rewards test file
wlycdgr 02a890a
Fix FoundBugs bug that kept any bugs from being blocked: true
wlycdgr 24b2d74
Clean up Blocking#render in process of implementing expand/collapse t…
wlycdgr b89c383
Fix function call typo in PanelData
wlycdgr 7052a98
Make sure extension loads correctly if there is no needsReload value …
wlycdgr 136a469
Implement per category expanded state preservation during loading in …
wlycdgr 0058677
Debug and cleanup expand/contract per category state preservation dur…
wlycdgr 3cb5167
Throttle DonutGraph#_bakeDonut
wlycdgr f49761f
Remove unnecessary totalCount parameter extraction & passing from Don…
wlycdgr 2b67b20
Restore immediate updating to redscale/greyscale in response to user …
wlycdgr 970ae9f
Animate donut graph reslicing. Delint code.
wlycdgr fa98388
Add padAngle TODO note to DonutGraph. Remove commented out code.
wlycdgr 6d32923
Merge branch 'develop' into feature/GH-1517_dynamic-UI-rendering
IAmThePan 09dac12
Merge in new browser-core build from develop
wlycdgr 7e8a130
Clean up merge comments from package.json
wlycdgr bd265d0
Merge branch 'feature/GH-1517_dynamic-UI-rendering' of github.com:gho…
wlycdgr c72c5db
Update yarn.lock
IAmThePan f1bef8d
Merge branch 'feature/GH-1517_dynamic-UI-rendering' of github.com:gho…
IAmThePan 2503fa0
Merge branch 'develop' into feature/GH-1517_dynamic-UI-rendering
jsignanini acded00
Rearrange function calls in Panel#componentDidMount
wlycdgr 1b61c2c
Change type of action created by updatePanelData back to GET_PANEL_DA…
wlycdgr 045bb6c
Merge branch 'develop' into feature/GH-1517_dynamic-UI-rendering
wlycdgr 773dafe
Remove a removeListener call that should not have been there from pan…
wlycdgr 4fd878e
Modify rewards ui port code & logic to match current behavior
wlycdgr b8f36db
Throttle PanelData#updatePanelUI to 600ms, matching the donut redraw …
wlycdgr 27b202b
Add and modify panel UI update throttling comments
wlycdgr 96da132
Send account data with panel updates to avoid account reducer error
wlycdgr 4869f71
Add performance analysis code
wlycdgr eeb926c
Add panel open performance logging
wlycdgr 4127122
Remove performance logging
wlycdgr 8df86d9
Remove performance analysis code
wlycdgr 4e24b96
Revert the remainder of performance measurement changes
wlycdgr