Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/gh 1517 dynamic ui rendering #343

Closed
wants to merge 129 commits into from
Closed

Feature/gh 1517 dynamic ui rendering #343

wants to merge 129 commits into from
+1,515 −1,250

Commits on Jan 30, 2019

  1. Convert PanelData export to a singleton to facilitate dynamic UI port… 

    … handling
    @wlycdgr
    wlycdgr committed Jan 30, 2019
    88fc5e4

  2. Add summaryUIPort

    @wlycdgr
    wlycdgr committed Jan 30, 2019
    51b2a00

Commits on Jan 31, 2019

  1. Move summaryUIPort to panel data. Create port initializion function

    @wlycdgr
    wlycdgr committed Jan 31, 2019
    2516435

  2. Add PanelData#updatePanelUI stub. Add call to this stub from eventsHa… 

    …ndler.
    @wlycdgr
    wlycdgr committed Jan 31, 2019
    b1996fe

Commits on Feb 1, 2019

  1. Create a map on panelData to store our multiple UI ports

    @wlycdgr
    wlycdgr committed Feb 1, 2019
    945245e

  2. Reorder port connect name checks to account for relative frequency

    @wlycdgr
    wlycdgr committed Feb 1, 2019
    a780efc

  3. Constantize summary ui port name

    @wlycdgr
    wlycdgr committed Feb 1, 2019
    3d14b93

  4. Update summary ui port name constant name

    @wlycdgr
    wlycdgr committed Feb 1, 2019
    adb5b45

  5. Disconnect summary UI port on component unmount

    @wlycdgr
    wlycdgr committed Feb 1, 2019
    fe19632

  6. Simplify logging to use existing utils api. revert port constant name

    @wlycdgr
    wlycdgr committed Feb 1, 2019
    705ae1c

  7. post message to Summary component on bug update

    @wlycdgr
    wlycdgr committed Feb 1, 2019
    3c64875

Commits on Feb 4, 2019

  1. Add TODOs. Comment out code for testing.

    @wlycdgr
    wlycdgr committed Feb 4, 2019
    87959b0

Commits on Feb 5, 2019

  1. Make tracker donut dynamic

    @wlycdgr
    wlycdgr committed Feb 5, 2019
    b7708c1

Commits on Feb 6, 2019

  1. Debug UI port flow and make sure the right tab objects are being pass… 

    …ed around
    @wlycdgr
    wlycdgr committed Feb 6, 2019
    96b4a72

  2. Define PanelData#updatePanelAndSummaryTrackerData, which performs onl… 

    …y the updates relevant to the Panel and Summary UIs
    @wlycdgr
    wlycdgr committed Feb 6, 2019
    d456d0c

Commits on Feb 7, 2019

  1. Refactor tracker data building in Panel Data to accomodate update use… 

    … case without duplication
    @wlycdgr
    wlycdgr committed Feb 7, 2019
    db70769

  2. Merge branch 'develop' into feature/GH-1517_dynamic-UI-rendering to b… 

    …rinch branch up to date with current develop state
    @wlycdgr
    wlycdgr committed Feb 7, 2019
    504bedf

  3. Revise PanelData updates to placate linter

    @wlycdgr
    wlycdgr committed Feb 7, 2019
    50be4ff

  4. Update variable names in PanelData and remove some testing code

    @wlycdgr
    wlycdgr committed Feb 7, 2019
    de84196

Commits on Feb 8, 2019

  1. Add data structure doc for per-tab apps memoization to FoundBugs

    @wlycdgr
    wlycdgr committed Feb 8, 2019
    768f142

Commits on Feb 11, 2019

  1. Refactor FoundBugs to speed up app retrieval

    @wlycdgr
    wlycdgr committed Feb 11, 2019
    b3b0f5c

  2. Fix typo in FoundBugs

    @wlycdgr
    wlycdgr committed Feb 11, 2019
    4ab94a4

  3. Fix typo and uncomment a necessary line

    @wlycdgr
    wlycdgr committed Feb 11, 2019
    f2d5751

Commits on Feb 12, 2019

  1. Debugging hasLatencyIssue bug

    @wlycdgr
    wlycdgr committed Feb 12, 2019
    0110050

  2. Merge branch 'develop' into feature/GH-1517_dynamic-UI-rendering to b… 

    …ring feature branch up to date with develop
    @wlycdgr
    wlycdgr committed Feb 12, 2019
    9c2c7a4

  3. Fix assignment bug in hasLatencyIssue and remove debugging statements

    @wlycdgr
    wlycdgr committed Feb 12, 2019
    b539fcf

  4. Clean up UI port listener in the Panel component

    @wlycdgr
    wlycdgr committed Feb 12, 2019
    86d3643

Commits on Feb 13, 2019

  1. Move summary ui port back to Summary component

    @wlycdgr
    wlycdgr committed Feb 13, 2019
    bd0d306

  2. Work on updating PanelData to handle update requests efficiently

    @wlycdgr
    wlycdgr committed Feb 13, 2019
    298d78b

  3. Continue PanelData refactor

    @wlycdgr
    wlycdgr committed Feb 13, 2019
    a240322

  4. Retrieve active tab on port init and store in PanelData to avoid retr… 

    …ieving each time there's a UI update
    @wlycdgr
    wlycdgr committed Feb 13, 2019
    cbaa7ee

  5. Continue to refactor PanelData

    @wlycdgr
    wlycdgr committed Feb 13, 2019
    149e84d

  6. Work in progress on PanelData

    @wlycdgr
    wlycdgr committed Feb 13, 2019
    27e0593

  7. Continue refactor of PanelData

    @wlycdgr
    wlycdgr committed Feb 13, 2019
    0faa19a

Commits on Feb 14, 2019

  1. Send init data on first time panel opens port on a tab

    @wlycdgr
    wlycdgr committed Feb 14, 2019
    786b778

  2. Use dynamic UI ports to retrieve initial panel data as well

    @wlycdgr
    wlycdgr committed Feb 14, 2019
    6fd1513

  3. Remove unnecessary functions from PanelData

    @wlycdgr
    wlycdgr committed Feb 14, 2019
    4b9e7f1

  4. Remove linear regression import from PanelData...not sure how it ende… 

    …d up in there...
    @wlycdgr
    wlycdgr committed Feb 14, 2019
    8f359bd

  5. Remove now-redundant panelView getter and object on PanelData

    @wlycdgr
    wlycdgr committed Feb 14, 2019
    edb8d69

  6. Remove dependence on building tracker data map in PanelData

    @wlycdgr
    wlycdgr committed Feb 14, 2019
    afabd8e

  7. Remove tracker data map from PanelData

    @wlycdgr
    wlycdgr committed Feb 14, 2019
    1f46583

  8. Linter placation fixes in PanelData

    @wlycdgr
    wlycdgr committed Feb 14, 2019
    bdee64c

  9. Delete private *View var that are only ever used to return from their… 

    … respective getters in PanelData
    @wlycdgr
    wlycdgr committed Feb 14, 2019
    79b49b6

Commits on Feb 15, 2019

  1. Work to remove redundant confData data structure in PanelData

    @wlycdgr
    wlycdgr committed Feb 15, 2019
    f51026a

  2. Fix subscriptionsPlus typo

    @wlycdgr
    wlycdgr committed Feb 15, 2019
    69478c7

  3. Delete this._confData get from this._buildCategories in PanelData

    @wlycdgr
    wlycdgr committed Feb 15, 2019
    185e2bd

  4. Remove this._buildConfData() from PanelData

    @wlycdgr
    wlycdgr committed Feb 15, 2019
    0ce4200

  5. Move updateSummaryData to SummaryActions

    @wlycdgr
    wlycdgr committed Feb 15, 2019
    5e0a907

  6. Add blocking UI port. Move retrieval of blocking data to this port.

    @wlycdgr
    wlycdgr committed Feb 15, 2019
    98dde48

  7. Activate blockingUIPort

    @wlycdgr
    wlycdgr committed Feb 15, 2019
    5ebb380

  8. Clean up unnecessary code and comments

    @wlycdgr
    wlycdgr committed Feb 15, 2019
    154baf5

  9. Convert Settings component to use port to get initial settings data

    @wlycdgr
    wlycdgr committed Feb 15, 2019
    7d139ad

  10. Remove unnecessary call in Settings

    @wlycdgr
    wlycdgr committed Feb 15, 2019
    67367fb

  11. Remove this._buildConfData call in PanelData#set

    @wlycdgr
    wlycdgr committed Feb 15, 2019
    6d505c3

  12. Update account.getUserSettings error message to reflect that it now l… 

    …ives in PanelData#initUIPort
    @wlycdgr
    wlycdgr committed Feb 15, 2019
    b232349

  13. Remove log statements from Panel and Summary render funcs

    @wlycdgr
    wlycdgr committed Feb 15, 2019
    3516412

  14. Move rewards panel port to PanelData. Modify front and back end code … 

    …towards using the port to retrieve the rewards info.
    @wlycdgr
    wlycdgr committed Feb 15, 2019
    9968d2a

  15. Implement passing rewards panel data through PanelData port

    @wlycdgr
    wlycdgr committed Feb 15, 2019
    a3fd2d0

  16. Remove obviated Rewards panel background data retrieval code

    @wlycdgr
    wlycdgr committed Feb 15, 2019
    b4bc375

  17. Remove obviated PanelData#get

    @wlycdgr
    wlycdgr committed Feb 15, 2019
    287c034

  18. Clean up PanelData#initUIPort

    @wlycdgr
    wlycdgr committed Feb 15, 2019
    1bc265c

  19. Remove outdated PanelData constructor comment

    @wlycdgr
    wlycdgr committed Feb 15, 2019
    051435d

  20. Add comments to PanelData

    @wlycdgr
    wlycdgr committed Feb 15, 2019
    efda3dd

  21. Remove variable related to removed PanelData conf Map from PanelData#set

    @wlycdgr
    wlycdgr committed Feb 15, 2019
    bde6e1b

Commits on Feb 16, 2019

  1. Minor change to reduce duplication in PanelData#set

    @wlycdgr
    wlycdgr committed Feb 16, 2019
    ff16c6d

  2. Factor some duplicate code in PanelData#set out to a helper func

    @wlycdgr
    wlycdgr committed Feb 16, 2019
    d29e5dc

  3. Remove commented out code from PanelData#set

    @wlycdgr
    wlycdgr committed Feb 16, 2019
    aab593b

  4. Work towards converting getCliqzModuleData to use the summary UI port… 

    … and moving the relevant code to PanelData
    @wlycdgr
    wlycdgr committed Feb 16, 2019
    4fcc7e1

Commits on Feb 18, 2019

  1. Modify GET_CLIQZ_MODULE_DATA reducer to look for 'blocked' rather tha… 

    …n 'unsafe' when calculating total unsafe count
    @wlycdgr
    wlycdgr committed Feb 18, 2019
    1571067

  2. Remove code that was used to get cliqz module data via messages, sinc… 

    …e we are nnow getting it through ports
    @wlycdgr
    wlycdgr committed Feb 18, 2019
    84e7a57

Commits on Feb 19, 2019

  1. Update BrowserButton#_getAntiTrackCount to check for 'blocked' rather… 

    … than 'unsafe'. Remove debug log calls.
    @wlycdgr
    wlycdgr committed Feb 19, 2019
    4b689bb

  2. Move cliqz antitracking and adblocking data retrieval to utils functi… 

    …ons. Converted BrowserButton to use them
    @wlycdgr
    wlycdgr committed Feb 19, 2019
    1409296

  3. Remove unnecessary imports from BrowserButton. Linter clean up.

    @wlycdgr
    wlycdgr committed Feb 19, 2019
    e9aa8e3

  4. Convert PanelData to use the cliqzModuleData utility functions

    @wlycdgr
    wlycdgr committed Feb 19, 2019
    baddd40

  5. Remove redundant unsafe count calculation from GET_CLIQZ_MODULE_DATA … 

    …reducer
    @wlycdgr
    wlycdgr committed Feb 19, 2019
    d30c723

  6. Revert to 'unsafe' in cliqModuleData and remove some logging calls

    @wlycdgr
    wlycdgr committed Feb 19, 2019
    f168850

  7. Update GET_REWARDS_DATA test

    @wlycdgr
    wlycdgr committed Feb 19, 2019
    e67eb83

  8. Update GET_CLIQZ_MODULE_DATA reducer and action creator tests

    @wlycdgr
    wlycdgr committed Feb 19, 2019
    b900205

  9. Make donut arc a property on DonutGraph

    @wlycdgr
    wlycdgr committed Feb 19, 2019
    df0b2fb

  10. Make trackerPie a property on DonutGraph

    @wlycdgr
    wlycdgr committed Feb 19, 2019
    09f9171

Commits on Feb 20, 2019

  1. Move towards correct updating of donut graph, without adding new elem… 

    …ents each time
    @wlycdgr
    wlycdgr committed Feb 20, 2019
    4d5c8f6

  2. Implement donut updating without adding new SVG elements

    @wlycdgr
    wlycdgr committed Feb 20, 2019
    b4a5633

  3. Begin adding UI state to Blocking to preserve per category expansion … 

    …state across updates
    @wlycdgr
    wlycdgr committed Feb 20, 2019
    69eeb21

  4. Always send blocking data on opening of blocking port instead of only… 

    … on updates or through panel init, making sure that blocking data is always fetched when user switches to detailed tab, even if page has finished loading and no more updates come in
    @wlycdgr
    wlycdgr committed Feb 20, 2019
    968d1e2

  5. Reduce duplicdation in data retrieval functions in PanelData. Streaml… 

    …ine panel data updates to use UPDATE_PANEL_DATA and so remove GET_PANEL_DATA action creator and reducer case
    @wlycdgr
    wlycdgr committed Feb 20, 2019
    1198e8a

  6. Make sure rewards UI port disconnects. Handle detaching disconnect li… 

    …stener through PanelData
    @wlycdgr
    wlycdgr committed Feb 20, 2019
    c95447d

Commits on Feb 21, 2019

  1. Reset page load time display if page is reloaded while panel is open

    @wlycdgr
    wlycdgr committed Feb 21, 2019
    209bda4

  2. Ensure that page load data is sent even if panel is first opened afte… 

    …r page has finished loading
    @wlycdgr
    wlycdgr committed Feb 21, 2019
    af2e4ba

Commits on Feb 25, 2019

  1. Work towards finalizing the API, organization, and documentation of P… 

    …anelData
    @wlycdgr
    wlycdgr committed Feb 25, 2019
    3c4f4d6

Commits on Feb 26, 2019

  1. Continue finalizing refactor of PanelData

    @wlycdgr
    wlycdgr committed Feb 26, 2019
    c3433ac

  2. Finish PanelData refactor and reorganization. Fix typo in FoundBugs

    @wlycdgr
    wlycdgr committed Feb 26, 2019
    8baf15a

  3. Fix bug in summary data retrieval

    @wlycdgr
    wlycdgr committed Feb 26, 2019
    db0e44b

  4. Add TODO comment to RewardsActions. Modify ui port code to make sure … 

    …it's compatible with snapshot testing the Rewards component
    @wlycdgr
    wlycdgr committed Feb 26, 2019
    0facec1

  5. Remove extraneous param listing from FoundBugs#update comment

    @wlycdgr
    wlycdgr committed Feb 26, 2019
    00ee717

  6. Remove commented out code block and unused import from foundbugs.test.js

    @wlycdgr
    wlycdgr committed Feb 26, 2019
    6c9416c

  7. Fix minor typos in foundbugs.test.js

    @wlycdgr
    wlycdgr committed Feb 26, 2019
    a85bcc8

  8. Remove some debug logging from Rewards component. Update Rewards comp… 

    …onent tests to use sinon to stub chrome.runtime.connect
    @wlycdgr
    wlycdgr committed Feb 26, 2019
    0926253

  9. Remove unnecessary sinon import from Rewards test file

    @wlycdgr
    wlycdgr committed Feb 26, 2019
    3d61faf

  10. Fix FoundBugs bug that kept any bugs from being blocked: true

    @wlycdgr
    wlycdgr committed Feb 26, 2019
    02a890a

  11. Clean up Blocking#render in process of implementing expand/collapse t… 

    …racking
    @wlycdgr
    wlycdgr committed Feb 26, 2019
    24b2d74

  12. Fix function call typo in PanelData

    @wlycdgr
    wlycdgr committed Feb 26, 2019
    b89c383

Commits on Feb 27, 2019

  1. Make sure extension loads correctly if there is no needsReload value … 

    …set for the tab
    @wlycdgr
    wlycdgr committed Feb 27, 2019
    7052a98

  2. Implement per category expanded state preservation during loading in … 

    …blocking view
    @wlycdgr
    wlycdgr committed Feb 27, 2019
    136a469

  3. Debug and cleanup expand/contract per category state preservation dur… 

    …ing dyanmic updating. Remove now unncecessary action creator reducer and utility function code
    @wlycdgr
    wlycdgr committed Feb 27, 2019
    0058677

Commits on Feb 28, 2019

  1. Throttle DonutGraph#_bakeDonut

    @wlycdgr
    wlycdgr committed Feb 28, 2019
    3cb5167

  2. Remove unnecessary totalCount parameter extraction & passing from Don… 

    …utGraph
    @wlycdgr
    wlycdgr committed Feb 28, 2019
    f49761f

  3. Restore immediate updating to redscale/greyscale in response to user … 

    …restricting site or pausing the extension
    @wlycdgr
    wlycdgr committed Feb 28, 2019
    2b67b20

  4. Animate donut graph reslicing. Delint code.

    @wlycdgr
    wlycdgr committed Feb 28, 2019
    970ae9f

  5. Add padAngle TODO note to DonutGraph. Remove commented out code.

    @wlycdgr
    wlycdgr committed Feb 28, 2019
    fa98388

  6. Merge branch 'develop' into feature/GH-1517_dynamic-UI-rendering

    @IAmThePan
    IAmThePan committed Feb 28, 2019
    6d32923

  7. Merge in new browser-core build from develop

    @wlycdgr
    wlycdgr committed Feb 28, 2019
    09dac12

  8. Clean up merge comments from package.json

    @wlycdgr
    wlycdgr committed Feb 28, 2019
    7e8a130

  9. Merge branch 'feature/GH-1517_dynamic-UI-rendering' of github.com:gho… 

    …stery/ghostery-extension into feature/GH-1517_dynamic-UI-rendering
    @wlycdgr
    wlycdgr committed Feb 28, 2019
    bd265d0

  10. Update yarn.lock

    @IAmThePan
    IAmThePan committed Feb 28, 2019
    c72c5db

  11. Merge branch 'feature/GH-1517_dynamic-UI-rendering' of github.com:gho… 

    …stery/ghostery-extension into feature/GH-1517_dynamic-UI-rendering
    @IAmThePan
    IAmThePan committed Feb 28, 2019
    f1bef8d

Commits on Mar 4, 2019

  1. Merge branch 'develop' into feature/GH-1517_dynamic-UI-rendering

    @jsignanini
    jsignanini committed Mar 4, 2019
    2503fa0

  2. Rearrange function calls in Panel#componentDidMount

    @wlycdgr
    wlycdgr committed Mar 4, 2019
    acded00

  3. Change type of action created by updatePanelData back to GET_PANEL_DA… 

    …TA so as not to break AccountReducer, which relies on that name
    @wlycdgr
    wlycdgr committed Mar 4, 2019
    1b61c2c

Commits on Mar 5, 2019

  1. Merge branch 'develop' into feature/GH-1517_dynamic-UI-rendering

    @wlycdgr
    wlycdgr committed Mar 5, 2019
    045bb6c

  2. Remove a removeListener call that should not have been there from pan… 

    …elData
    @wlycdgr
    wlycdgr committed Mar 5, 2019
    773dafe

  3. Modify rewards ui port code & logic to match current behavior

    @wlycdgr
    wlycdgr committed Mar 5, 2019
    4fd878e

Commits on Mar 7, 2019

  1. Throttle PanelData#updatePanelUI to 600ms, matching the donut redraw … 

    …throttling
    @wlycdgr
    wlycdgr committed Mar 7, 2019
    b8f36db

  2. Add and modify panel UI update throttling comments

    @wlycdgr
    wlycdgr committed Mar 7, 2019
    27b202b

Commits on Mar 11, 2019

  1. Send account data with panel updates to avoid account reducer error

    @wlycdgr
    wlycdgr committed Mar 11, 2019
    96da132

Commits on Mar 12, 2019

  1. Add performance analysis code

    @wlycdgr
    wlycdgr committed Mar 12, 2019
    4869f71

  2. Add panel open performance logging

    @wlycdgr
    wlycdgr committed Mar 12, 2019
    eeb926c

  3. Remove performance logging

    @wlycdgr
    wlycdgr committed Mar 12, 2019
    4127122

  4. Remove performance analysis code

    @wlycdgr
    wlycdgr committed Mar 12, 2019
    8df86d9

  5. Revert the remainder of performance measurement changes

    @wlycdgr
    wlycdgr committed Mar 12, 2019
    4e24b96