Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cliqz Browser: Do not load human-web and offers #35

Closed
wants to merge 1 commit into from
Closed

Cliqz Browser: Do not load human-web and offers #35

wants to merge 1 commit into from

Conversation

@ghost
Copy link

@ghost ghost commented Apr 12, 2018

No description provided.

do not load the human-web and offers modules.
@ghost ghost requested a review from zarembsky as a code owner Apr 12, 2018
Copy link
Contributor

@zarembsky zarembsky left a comment

We need similar changes for antitracking and adblocking. All four modules come in enabled on install due to Cliqz config settings. Now when Ghostery conf changes in these assignments the dispatcher is called, see:
dispatcher.on('conf.save.enable_human_web', (enableHumanWeb) => {
if (!IS_EDGE && !IS_CLIQZ) {
setCliqzModuleEnabled(humanweb, enableHumanWeb).then((data) => {
if (data !== CORRECT_STATE) {
// We don't want to affect Offers here
setupABTestAntitracking();
}
});
});
And we need to add explicit else statement there, like this:
dispatcher.on('conf.save.enable_human_web', (enableHumanWeb) => {
if (!IS_EDGE && !IS_CLIQZ) {
setCliqzModuleEnabled(humanweb, enableHumanWeb).then((data) => {
if (data !== CORRECT_STATE) {
// We don't want to affect Offers here
setupABTestAntitracking();
}
});
} else {
setCliqzModuleEnabled(humanweb, false);
}
});

@zarembsky zarembsky closed this Apr 12, 2018
@zarembsky
Copy link
Contributor

@zarembsky zarembsky commented Apr 12, 2018

Suggestions will be used in another pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants