Throttle browser button counter updates #350
Merged
Conversation
|
@IAmThePan do you remember what issue we had with passing tabID to |
|
btw. we've tested this change on mobile browser and seems to work without any issues. Would be probably better to have an update queue as there are multiple sources of "badge" updates. |
|
I don't quite remember but I think there were inconsistencies where the passed TabId wasn't for the currently active tab.
|
|
regardless of correct behavior of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Counter updates can happen very fast and every update issues a call to chrome process. This change should improve performance - specifically for underpowered devices like mobiles.