Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress all .png images in the Hub #354

Merged
merged 4 commits into from Mar 11, 2019
Merged

Conversation

@IAmThePan
Copy link
Contributor

@IAmThePan IAmThePan commented Mar 7, 2019

I used https://tinypng.com/ to compress all of the .png files in app/images/hub. This reduced the size of the folder from 3.4 MB to 948 KB, and reduced the size of the package from 8.4 MB to 6.1 MB.
You can use the Display Rich Diff to compare the images. I couldn't tell the difference between any of the original and compressed images.

@IAmThePan IAmThePan requested a review from ghostery/ghostery as a code owner Mar 7, 2019
@IAmThePan
Copy link
Contributor Author

@IAmThePan IAmThePan commented Mar 8, 2019

I used Sketch to shrink the image sizes to match the sizes used throughout the extension. Then I used https://tinypng.com/ to compress the shrunken .png files. This further reduced the size of the app/images/hub to 625 KB and reduces the size of the package to 5.7 MB.
With this commit I am able to notice the reduced image quality, but maybe it is worth the saved bytes.

jsignanini added 2 commits Mar 11, 2019
@jsignanini jsignanini merged commit 5f954bc into develop Mar 11, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jsignanini jsignanini deleted the feature/compress-hub-images branch Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants