Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gh 1517 single port #355

Merged
merged 170 commits into from Mar 28, 2019
Merged

Feature/gh 1517 single port #355

merged 170 commits into from Mar 28, 2019

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Mar 13, 2019

Implements dynamic updating of the extension panel UI including the Summary and Detailed views. This includes dynamic updating of the various tracker counts as the page loads, dynamic insertion of trackers into the blocking list as they are found, and dynamic redrawing of the donut graph.

Streamlines all UI data transfer between the panel (including its Panel, Summary, Blocking, Settings, and Rewards components) and the background to use a single port managed by PanelData on the backend and passed through using the Context API on the React frontend, obviating all such transfer through message passing.

Factors out Cliqz antitracking and adblocking modules data retrieval into a utility file that both BrowserButton and PanelData can use, reducing duplication across BrowserButton and PanelData & the GET_CLIQZ_MODULE_DATA reducer on the front end.

Refactors FoundBugs to more efficiently handle the now potentially much larger volume of requests for bug info, primarily by storing foundApps data alongside foundBugs data so it does not need to be repeatedly recalculated.

Refactors and simplifies PanelData.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • [N/A] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
wlycdgr added 30 commits Jan 30, 2019
…y the updates relevant to the Panel and Summary UIs
…rinch branch up to date with current develop state
…ring feature branch up to date with develop
wlycdgr and others added 14 commits Mar 15, 2019
…k should now be fixed in all components.
…t that were there to prevent test breakage
…ng typo for that flie.
…y the needs of the android panel
… Android panel still need it
… and in Hub Blocking Dropdown
Copy link
Member

@jsignanini jsignanini left a comment

@wlycdgr let's rework it so that it follows this sequence:

  1. panel is opened
  2. get all panelData at that point in time and send to panel to display
  3. concurrently, trigger a call to getUserSettings(), once it returns, if the panel is still open, stream the new settings data to panel to display (through the same method as point 2)
  4. from now on, the only data streamed live to the panel is non-persistent data: tabInfo, apps, trackers, page load times, etc. Basically data that only lives for the "tab" session
wlycdgr added 2 commits Mar 19, 2019
…s. Do not send conf data in updates to panel
@wlycdgr
Copy link
Member Author

@wlycdgr wlycdgr commented Mar 19, 2019

@jsignanini I've rewritten and reorganized PanelData to follow the sequence you outlined.

Copy link
Member

@jsignanini jsignanini left a comment

@wlycdgr panel shows blank (check console.log for errors) when opening on chrome://* or chrome-extension://* pages right after install.

@wlycdgr
Copy link
Member Author

@wlycdgr wlycdgr commented Mar 27, 2019

@wlycdgr panel shows blank (check console.log for errors) when opening on chrome://* or chrome-extension://* pages right after install.

@jsignanini fixed

jsignanini added 2 commits Mar 28, 2019
@jsignanini jsignanini merged commit 7cf5c0b into develop Mar 28, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jsignanini jsignanini deleted the feature/GH-1517_single_port branch Mar 28, 2019
@jsignanini jsignanini mentioned this pull request Mar 28, 2019
5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants