Reorder work in EventHandlers#onBeforeRequest to increase speed #358
Conversation
…Bug calculations when the request is insecure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
EventHandlers#onBeforeRequest currently calls isBug before calling PolicySmartBlock.isInsecureRequest and returning immediately if that second call returns true. But this second call does not rely on the results of the expensive call to isBug, which also does not produce any side effects I've been able to notice. So I moved the isBug call below the call to isInsecureRequest.