Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EX-8836: Enforce offers-v2 state for Ghostery #360

Merged
merged 3 commits into from Apr 1, 2019
Merged

EX-8836: Enforce offers-v2 state for Ghostery #360

merged 3 commits into from Apr 1, 2019

Conversation

@aleksandr-cliqz
Copy link
Contributor

@aleksandr-cliqz aleksandr-cliqz commented Mar 22, 2019

https://cliqztix.atlassian.net/browse/EX-8836

@trickpattyFH20

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
Aleksandr Panin
EX-8836: adding filterOffersByRemoteIfNeeded function
Loading status checks…
b9d78a7
@zarembsky
Copy link
Contributor

@zarembsky zarembsky commented Mar 26, 2019

Please get rid of spread syntax in Rewards.js, filterOffersByRemote. Edge does not take it.
Aleksandr Panin
EX-8836: removing spread operator
Loading status checks…
37ffa66
@aleksandr-cliqz
Copy link
Contributor Author

@aleksandr-cliqz aleksandr-cliqz commented Mar 27, 2019

@zarembsky done
@jsignanini
Merge branch 'develop' into EX-8836_enforce_rewards_state
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
1db710c
@jsignanini
jsignanini approved these changes Apr 1, 2019
View changes
@jsignanini jsignanini merged commit 5e1d7e8 into ghostery:develop Apr 1, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignanini jsignanini

@trickpattyFH20 trickpattyFH20

@zarembsky zarembsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@aleksandr-cliqz @zarembsky @jsignanini @christophertino