Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1644: Fix Unchecked runtime.lastError in message handler #362

Merged
merged 7 commits into from Apr 2, 2019
Merged

GH-1644: Fix Unchecked runtime.lastError in message handler #362

merged 7 commits into from Apr 2, 2019
+69 −97

Conversation

@christophertino
Copy link
Member

@christophertino christophertino commented Mar 29, 2019

  • Removed duplicated messaging code from content-script and panel utils msg.js
  • Added default callback handler to catch Unchecked runtime.lastError: The message port closed before a response was received
  • Fixed error in account reducer Cannot destructure property userID of 'undefined' or 'null'.
@christophertino
consolidate and refactor sendMessage methods
Loading status checks…
c19dc89
@christophertino christophertino requested review from trickpattyFH20 and ghostery/ghostery as code owners Mar 29, 2019
@christophertino christophertino requested review from jsignanini and zarembsky Mar 29, 2019
@christophertino
fix lint errors
Loading status checks…
a021659
@zarembsky
zarembsky approved these changes Mar 29, 2019
View changes
Copy link
Contributor

@zarembsky zarembsky left a comment

Code looks good. Local branch of off this pull request does not show SendMessage related errors.
@christophertino christophertino removed the request for review from trickpattyFH20 Mar 29, 2019
@christophertino
handle runtime lasterror on sendMessage calls
Loading status checks…
67c74d7
@christophertino
update browser core
Loading status checks…
61c2b8b
@christophertino
update readme #341
Loading status checks…
15a4a1c
@christophertino
revert falsey check on account reducer
Loading status checks…
7f602af
@christophertino
Merge branch 'develop' into feature/GH-1644
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
da8174f
@christophertino christophertino merged commit e8e2bdf into develop Apr 2, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jsignanini jsignanini deleted the feature/GH-1644 branch Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zarembsky zarembsky

@jsignanini jsignanini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@christophertino @zarembsky