Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with the Adblocker API in browser-core v7.36 #363

Merged
merged 2 commits into from Apr 23, 2019
Merged

Compatibility with the Adblocker API in browser-core v7.36 #363

merged 2 commits into from Apr 23, 2019

Conversation

@philipp-classen
Copy link
Contributor

@philipp-classen philipp-classen commented Apr 1, 2019

When we upgrade to browser-core 7.36 (or higher), the API of the Adblocker will change. This patch shows how to updates the API in Ghostery.

Do not merge before upgrading to browser-core 7.36.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@philipp-classen
Update for the changed adblocker API in browser-core 7.36.
Verified
This commit was signed with the committer’s verified signature.
philipp-classen Philipp Claßen
GPG key ID: FB26C3629A17E6F0 Learn about vigilant mode.
Loading status checks…
8a1d89c
@philipp-classen philipp-classen requested review from zarembsky and ghostery/ghostery as code owners Apr 1, 2019
@jsignanini
jsignanini requested changes Apr 1, 2019
View changes
Copy link
Member

@jsignanini jsignanini left a comment

@philipp-classen could you run yarn and commit the updated yarn.lock file please?
@jsignanini
Merge branch 'develop' into adblocker_in_v7_36
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
e7edd11
@jsignanini
jsignanini approved these changes Apr 23, 2019
View changes
@jsignanini jsignanini merged commit 8a258c7 into ghostery:develop Apr 23, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@philipp-classen philipp-classen deleted the philipp-classen:adblocker_in_v7_36 branch Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignanini jsignanini

@zarembsky zarembsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@philipp-classen @jsignanini @christophertino