Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove object spread operator from PanelData #364

Merged
merged 2 commits into from Apr 2, 2019
Merged

Remove object spread operator from PanelData #364

merged 2 commits into from Apr 2, 2019

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Apr 1, 2019

Edge does not support the spread operator for objects; this removes that operator from PanelData to avoid adding an additional transpiler plugin dependency.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@wlycdgr
Remove object spread operator from PanelData
Loading status checks…
90cf1ed
@wlycdgr wlycdgr requested a review from zarembsky as a code owner Apr 1, 2019
@wlycdgr wlycdgr requested a review from jsignanini Apr 2, 2019
@jsignanini
Merge branch 'develop' into remove_spread_operator_from_background_to…
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
6a7d39a 
…_placate_Edge
@jsignanini
jsignanini approved these changes Apr 2, 2019
View changes
@christophertino christophertino merged commit cf3fdf9 into develop Apr 2, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the remove_spread_operator_from_background_to_placate_Edge branch Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignanini jsignanini

@zarembsky zarembsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@wlycdgr @jsignanini @christophertino