Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failure to display rewards data correctly in Panel rewards view #367

Merged
merged 1 commit into from Apr 2, 2019
Merged

Fix failure to display rewards data correctly in Panel rewards view #367

merged 1 commit into from Apr 2, 2019

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Apr 2, 2019

Rewards view was always incorrectly showing rewards as loading. This fixes that so that we see a 'no rewards' message if there are no rewards and the list of rewards if there are some.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@wlycdgr
Fix failure to display rewards data correctly in Panel rewards view
Loading status checks…
166f98b
@wlycdgr wlycdgr requested a review from zarembsky as a code owner Apr 2, 2019
@wlycdgr wlycdgr requested review from jsignanini and christophertino Apr 2, 2019
@christophertino
christophertino approved these changes Apr 2, 2019
View changes
@christophertino christophertino merged commit 57008cb into develop Apr 2, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the GH-1517_rewards-view-fix branch Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@zarembsky zarembsky

@jsignanini jsignanini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@wlycdgr @christophertino