Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for messaging in Edge (GH-1670) #368

Merged
merged 3 commits into from Apr 3, 2019
Merged

Fix for messaging in Edge (GH-1670) #368

merged 3 commits into from Apr 3, 2019

Conversation

@zarembsky
Copy link
Contributor

@zarembsky zarembsky commented Apr 2, 2019

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
zarembsky added 2 commits Apr 2, 2019
@zarembsky
Fix for sendMessageInPromise on Edge.
df8a251
@zarembsky
Merge branch 'develop' into feature/edgeMessagingFix
Loading status checks…
3afe22b
@zarembsky zarembsky requested review from IAmThePan, jsignanini, trickpattyFH20 and ghostery/ghostery as code owners Apr 2, 2019
@zarembsky zarembsky changed the base branch from master to develop Apr 2, 2019
@zarembsky
Additional fix.
Loading status checks…
ca35509
@jsignanini jsignanini self-assigned this Apr 3, 2019
@jsignanini
jsignanini approved these changes Apr 3, 2019
View changes
@jsignanini jsignanini merged commit 179a783 into develop Apr 3, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jsignanini jsignanini deleted the feature/edgeMessagingFix branch Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignanini jsignanini

@IAmThePan IAmThePan

@trickpattyFH20 trickpattyFH20

Assignees

@jsignanini jsignanini

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@zarembsky @jsignanini