Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix blocked_redirect by fixing promises and images #379

Closed
wants to merge 1 commit into from
Closed

Fix blocked_redirect by fixing promises and images #379

wants to merge 1 commit into from

Conversation

@IAmThePan
Copy link
Contributor

@IAmThePan IAmThePan commented May 7, 2019

Fix Blocked Redirect:

  • Fix images from not showing. I did this with as little change to the code as possible. The solution was to just add PNG files to the extension.
  • Fix promises and sendMessageInPromise to return correctly. There was an extra set of () that prevented sendMessageInPromise from returning correctly. There was also no return in content-scripts/utils/msg's sendMessageInPromise which prevented the function from correctly returning a promise.

@christophertino Please approve.
@IAmThePan
Fix blocked_redirect by fixing promises and images
Loading status checks…
69ae9ae
@IAmThePan IAmThePan requested a review from ghostery/ghostery as a code owner May 7, 2019
@christophertino christophertino changed the base branch from develop to hotfix/8.3.4 May 7, 2019
@IAmThePan IAmThePan mentioned this pull request May 7, 2019
Merged
@christophertino christophertino changed the base branch from hotfix/8.3.4 to develop May 7, 2019
@christophertino
Copy link
Member

@christophertino christophertino commented May 7, 2019

Closing in favor of #380
@christophertino christophertino deleted the fix/blocked-redirect branch May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghostery/ghostery Ghostery

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@IAmThePan @christophertino