Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blocked_redirect by fixing promises and images #380

Merged
merged 5 commits into from May 8, 2019

Conversation

@IAmThePan
Copy link
Contributor

@IAmThePan IAmThePan commented May 7, 2019

Duplicate of PR #379 but off the Hotfix branch:

Fix Blocked Redirect:

  • Fix images from not showing. I did this with as little change to the code as possible. The solution was to just add PNG files to the extension.
  • Fix promises and sendMessageInPromise to return correctly. There was an extra set of () that prevented sendMessageInPromise from returning correctly. There was also no return in content-scripts/utils/msg's sendMessageInPromise which prevented the function from correctly returning a promise.

@christophertino Please approve.

@IAmThePan IAmThePan requested a review from ghostery/ghostery as a code owner May 7, 2019
@christophertino
Copy link
Member

@christophertino christophertino commented May 7, 2019

This fixes #376

@christophertino christophertino merged commit 94e47e7 into hotfix/8.3.4 May 8, 2019
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@christophertino christophertino deleted the fix/blocking-redirect-hotfix branch May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants