Hotfix/call filter offers by remote on panel open #384
Conversation
GH-1595: add tooltip for historical stats icon in simple view
* Remove old Plus banner/logo * Add green upgrade banner to Summary component * Add upgrade banner class * Fix classNames -> className typo * Implement CSS for green upgrade banner * Display smaller upgrade banner in summary view when on detailed tab * Adjust position of smaller upgrade banner upwards a little to avoid overlapping the donut * Add gold subscriber icon to display when a subscribed user is signed in * Finish implementation of plus upgrade banner and gold icon display logic for the case when the panel is not both in detailed view and expanded * Remove debug code and redundant variable from Summary#render * Refactor Summary#render for clarity * Add green upgrade banner and gold plus icon SVGs for expanded view * Add expanded view upgrade banner div stub to Header#render. Refactor and clean up Header#render a bit. * Display gold icon in expanded view if user is a logged-in subscriber * Stub click on badge in expanded view * Replicate dev behavior of badge clicking in Header in expanded view * Rename upgrade banner / gold plus badge click handler for clarity * Add badge CSS classes to extended view badges. These need updating * Correct subscriber redirect path for gold plus icon click handler in Header * Update badge CSS * Tweak CSS for expanded view upgrade banner and gold plus icon to spec * Remove reference to non-extant state.header from header container mapStateToProps. pass state.panel.is_expanded to Header * Implement show/hide logic for header upgrade banner and gold plus icon * Factor kebab div out to const for clarity in Header#render * Tweak gold plus icon expanded view SVG to make sure Plus is more centered, with Vinnie's approval. Refactor Header#render for clarity * Finish clarity refactor of Summary#render * Nudge summary content down in expert view so green upgrade banner can fit. Delete two unused scss partials * Adjust positioning of simple/detailed view upgrade banners and gold icons to spec * Add click handling for simple and detailed view upgrade banner and gold badge. Adjust CSS for them. * Switch between upgrade banner and gold icon in Summary view on sign in / out instead of on panel reopen * Decompose totalTrackersBlockedAndPageLoadTime in Summary#render * Remove duplication from return of Summary#render * Fix Summary view display in Midnight theme on Detailed tab. Realign green upgrade banner and gold icon accordingly. Add debug and log truebools back into manifest * Display subscriber badge in header in gold in Midnight theme * Add upgrade banner text to locale strings file. Remove SVG upgarde text. Replace it with a text span. * Finalize CSS for upgrade banner text. Delete duplicate upgrade banner SVG * Convert 'upgrade to' text in the green banner from SVG to text for smaller detail view banner * Make sure upgrade banner or subscriber badge display in the hamburger dropdown views * Modify upgrade banner to scale along with text that may vary in length by locale * Tweak scalable CSS for simple view upgrade banner * Dedupe upgrade banner render code. Clean up CSS. Make sure banners stretch in both detailed and summary views. * Restore mistakenly deleted gold Plus icon CSS * Fix Summary view alignment in Condensed mode
* Bump browser-core version. * Use new whitelisting API for anti-tracking module. * Remove unnecessary return statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ensure that filterOffersByRemote is called on extension panel open even though the panel no longer sends the 'getPanelData' message / uses messaging at all.