EX-8836: Ensure that filtered Cliqz rewards are retrieved on extension panel open #385
Conversation
|
looks good, thx) One issue (but we can live with this issue):
|
… well as expert view panel open. Do not call when getPanelData is called from Hub or Android
Addressed - rewards.filterOffersByRemote is now called in this case also. Also, removed unneeded call to rewards.filterOffersByRemote in response to requests for data from background by the Hub and the Android extension, as neither displays rewards details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ensure that filterOffersByRemote gets called on extension panel open even though the panel now communicates with the background exclusively through a port and no longer sends the 'getPanelData' message.