Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EX-8836: Ensure that filtered Cliqz rewards are retrieved on extension panel open #385

Merged
merged 2 commits into from Jun 10, 2019

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented May 23, 2019

Ensure that filterOffersByRemote gets called on extension panel open even though the panel now communicates with the background exclusively through a port and no longer sends the 'getPanelData' message.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@wlycdgr wlycdgr requested a review from zarembsky as a code owner May 23, 2019
@wlycdgr wlycdgr requested a review from christophertino May 23, 2019
@christophertino christophertino requested a review from aleksandr-cliqz May 23, 2019
Copy link
Contributor

@aleksandr-cliqz aleksandr-cliqz left a comment

looks good, thx)

One issue (but we can live with this issue):

  1. user clicks on ghostery's icon -> simple view
  2. user clicks on detailed view
  3. user clicks on rewards
    rewards.filterOffersByRemote was not called, but should be called
… well as expert view panel open. Do not call when getPanelData is called from Hub or Android
@wlycdgr
Copy link
Member Author

@wlycdgr wlycdgr commented May 28, 2019

looks good, thx)

One issue (but we can live with this issue):

1. user clicks on ghostery's icon -> simple view

2. user clicks on detailed view

3. user clicks on rewards
   `rewards.filterOffersByRemote` was not called, but should be called

Addressed - rewards.filterOffersByRemote is now called in this case also.

Also, removed unneeded call to rewards.filterOffersByRemote in response to requests for data from background by the Hub and the Android extension, as neither displays rewards details.

@jsignanini jsignanini changed the title Ensure that filtered Cliqz rewards are retrieved on extension panel open EX-8836: Ensure that filtered Cliqz rewards are retrieved on extension panel open Jun 10, 2019
@jsignanini jsignanini merged commit 3dc1632 into develop Jun 10, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jsignanini jsignanini deleted the hotfix/call-filterOffersByRemote-on-panel-open branch Jun 10, 2019
@christophertino christophertino added this to the 8.4.0 milestone Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants