Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/call filter offers by remote on rewards view open #387

Closed

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented May 28, 2019

Ensure that getStoredOffers in the Cliqz offers-v2 module is called both on ghostery-cc open when ghostery-cc is opened into expert view, and also on Rewards view open, as per @aleksandr-cliqz 's request.

Do not call getStoredOffers when the Hub and the Android version of the extension make requests for panel data, as neither displays rewards details.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
wlycdgr added 2 commits May 23, 2019
… well as expert view panel open. Do not call when getPanelData is called from Hub or Android
@wlycdgr wlycdgr requested a review from zarembsky as a code owner May 28, 2019
@wlycdgr wlycdgr closed this May 28, 2019
@wlycdgr wlycdgr deleted the hotfix/call-filterOffersByRemote-on-Rewards-view-open branch May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant