GH-1566 - Smart blocking should check for Click2Play #388
+119
−215
Conversation
christophertino
requested review from
jsignanini,
trickpattyFH20,
zarembsky and
ghostery/ghostery
as
code owners
|
The underscore implementation in Historical Stats looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
When a tracker is smart blocked, we should load the C2P template when necessary. In these cases, we only show the "allow always" option since most of these widgets load on user interaction (lazy load) or beyond domComplete, negating the "allow once" option.
@wlycdgr @Eden12345 please make sure those lodash replacements look ok.