Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1566 - Smart blocking should check for Click2Play #388

Merged
merged 9 commits into from Jun 11, 2019

Remove unused condition.

  • Loading branch information
jsignanini committed Jun 11, 2019
commit 3e395a57e3c9309920e04d206c3f2efba0ada569
@@ -99,12 +99,9 @@ class PolicySmartBlock {
reason = 'allowedType'; // allow if tracker is in breaking type
} else if (this._pageWasReloaded(tabId, appId)) {
reason = 'pageReloaded'; // allow if page has been reloaded recently
} else if (c2pDb.allowedOnce(tabId, appId)) {
reason = 'c2pAllowOnce'; // allow if the user has selected "allow once" in Click2Play
}
}

// We are only blocking slow trackers that do not cause page breakage
const result = (reason === 'slow');
if (result) {
log('Smart Blocking blocked appId', appId, 'for reason:', reason);
ProTip! Use n and p to navigate between commits in a pull request.