Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1566 - Smart blocking should check for Click2Play #388

Merged
merged 9 commits into from Jun 11, 2019

Destructure underscore lib imports in front-end.

  • Loading branch information
jsignanini committed Jun 11, 2019
commit 93f3d7cfc099530349af385fd5dcef5b20f6c457
@@ -11,7 +11,7 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0
*/

import _ from 'underscore';
import { throttle } from 'underscore';
import React from 'react';
import ClassNames from 'classnames';
import {
@@ -178,7 +178,7 @@ class DonutGraph extends React.Component {
* @param {Array} categories list of categories detected on the site
* @param {Object} options options for the graph
*/
bakeDonut = _.throttle(this._bakeDonut.bind(this), 600, { leading: true, trailing: true }) // matches panelData#updatePanelUI throttling
bakeDonut = throttle(this._bakeDonut.bind(this), 600, { leading: true, trailing: true }) // matches panelData#updatePanelUI throttling

_bakeDonut(categories, options) {
const {
@@ -11,7 +11,7 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0
*/

import _ from 'underscore';
import { isEqual } from 'underscore';
import React from 'react';
import * as D3 from 'd3';

@@ -30,7 +30,7 @@ class StatsGraph extends React.Component {
* Lifecycle event
*/
componentDidUpdate(prevProps) {
if (!_.isEqual(prevProps, this.props)) {
if (!isEqual(prevProps, this.props)) {
this.generateGraph();
}
}
ProTip! Use n and p to navigate between commits in a pull request.