GH-1675: total requests modified readout (& summary refactors) #392
Conversation
…verlapping the donut
…gic for the case when the panel is not both in detailed view and expanded
…and clean up Header#render a bit.
…StateToProps. pass state.panel.is_expanded to Header
…ered, with Vinnie's approval. Refactor Header#render for clarity
… fit. Delete two unused scss partials
…and Cliqz features
|
There is a lot to look at here. I did a first pass and found a few things. I was really just looking for major issues and I didn't find any. |
…. Remove commented code in ghostery_feature.scss
|
Fixed the issues noted so far. |
* Remove count from Cliqz Features, replace with ON/OFF indicator * Stop passing now unneeded data prop to CliqzFeature
|
All outstanding comments addressed - ready for additional review |
|
Looks good to me. Jose is going to do his own review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This pull request covers the following tickets:
GH-1675: Implement the Total Requests Modified readout in the Summary view
GH-1718: Remove outdated abPause JSX and CSS from Summary, its sub-components, and related SCSS partials
GH-1719: BEMify Summary SCSS partial and the partials of its sub-components. This includes _cliqz_feautre, _ghostery_feature, _donut_graph, and parts of _tooltip. _pause_button has not been updated yet due to higher pressing priorities.
GH-1721: Generalize CliqzFeatures out to CliqzFeature. Component now more modular.
GH-1722: Generalize GhosteryFeatures out to GhosteryFeature. Component now more modular.
GH-1723: Decouple CliqzFeature from Summary. CliqzFeature no longer knows or cares about its presentation context.
GH-1724. Decouple GhosteryFeature from Summary. GhosteryFeature no longer knows or cares about its presentation context.