Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove count from Cliqz Features, replace with ON/OFF indicator #393

Merged
merged 2 commits into from Jun 10, 2019
Merged

Remove count from Cliqz Features, replace with ON/OFF indicator #393

merged 2 commits into from Jun 10, 2019
+13 −62

Conversation

@IAmThePan
Copy link
Contributor

@IAmThePan IAmThePan commented Jun 10, 2019 •
edited

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@IAmThePan
Remove count from Cliqz Features, replace with ON/OFF indicator
Loading status checks…
a01917d
@IAmThePan IAmThePan requested a review from ghostery/ghostery as a code owner Jun 10, 2019
@IAmThePan IAmThePan self-assigned this Jun 10, 2019
@IAmThePan IAmThePan requested a review from wlycdgr Jun 10, 2019
@wlycdgr
wlycdgr reviewed Jun 10, 2019
View changes
app/panel/components/BuildingBlocks/CliqzFeature.jsx Show resolved Hide resolved
@wlycdgr
Stop passing now unneeded data prop to CliqzFeature
Loading status checks…
c727784
@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Jun 10, 2019

Looks good
@wlycdgr wlycdgr merged commit 870b9c8 into GH-1675_TrackerListBreakdown-TotalCount Jun 10, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@IAmThePan IAmThePan deleted the feature/gh-1701 branch Jun 11, 2019
@christophertino christophertino added this to the 8.4.0 milestone Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlycdgr wlycdgr

Assignees

@IAmThePan IAmThePan

Labels
None yet
Projects
None yet
Milestone
8.4.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@IAmThePan @wlycdgr @christophertino