GH-1616: tracker list breakdown detailed view #394
Merged
Conversation
…f this bit out to a render helper in Tracker component
…fingerprint count readouts
…ground to Tracker component and their display there
|
I managed to get a fingerprint shown, looks good!
|
|
Ads portion of GH-1616 implemented |
…ats does not match an app id in the PanelData _trackerList
|
Fix bug where panel would not display if a bug id returned by getGhosteryStats did not map to an app id in our PanelData trackerList |
…the strings themselves as the keys.
|
Looks good. Only 211 lines and 8 files changed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Show additional Cliqz details for each tracker in the detailed view: number of cookies blocked / fingerprints wiped by Cliqz for this tracker, if any.
Does not implement the ad portion of the ticket, as discussed.Now implements the ad portion of the ticket also.Note that I haven't been able to find a fingerprint hit in the wild to confirm that it is passed through correctly from the background. However, I've confirmed that the fingerprint readout as well as the cookie readout displays correctly when passed dummy data on the front end.