Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/trust restrict pause hover state colors #398

Merged
merged 3 commits into from Jun 18, 2019
Merged

Bugfix/trust restrict pause hover state colors #398

merged 3 commits into from Jun 18, 2019

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Jun 18, 2019

Restores color-on-hover behavior of trust, restrict, and pause buttons to what's in production, while retaining the disabling of hover on trust and restrict while extension is paused.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
wlycdgr added 2 commits Jun 18, 2019
@wlycdgr
Restore trust restrict and pause button hover state color behavior to…
Loading status checks…
fd07f59 
… match production
@wlycdgr
Merge branch 'develop' into bugfix/trust-restrict-pause-hover-state-c…
Loading status checks…
783b4f8 
…olors
@wlycdgr wlycdgr requested a review from ghostery/ghostery as a code owner Jun 18, 2019
@wlycdgr wlycdgr requested review from christophertino and jsignanini Jun 18, 2019
@jsignanini
jsignanini approved these changes Jun 18, 2019
View changes
@jsignanini jsignanini self-requested a review Jun 18, 2019
@wlycdgr
Modify color-on-hover behavior of trust, restrict, pause buttons
Loading status checks…
29d9995
@jsignanini
jsignanini approved these changes Jun 18, 2019
View changes
@jsignanini jsignanini merged commit 08baa72 into develop Jun 18, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jsignanini jsignanini deleted the bugfix/trust-restrict-pause-hover-state-colors branch Jun 18, 2019
@christophertino christophertino added this to the 8.4.0 milestone Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignanini jsignanini

@christophertino christophertino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.4.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@wlycdgr @jsignanini @christophertino