Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for discrepancies in reported Smart Block numbers (GH-952) #40

Merged
merged 3 commits into from Apr 23, 2018
Merged

Fix for discrepancies in reported Smart Block numbers (GH-952) #40

merged 3 commits into from Apr 23, 2018

Conversation

@zarembsky
Copy link
Contributor

@zarembsky zarembsky commented Apr 18, 2018 •
edited by trickpattyFH20

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
Serge Zarembsky
Fix for GH-952
Loading status checks…
fe7812b
@zarembsky zarembsky requested a review from ghostery/ghostery as a code owner Apr 18, 2018
@zarembsky zarembsky changed the title Fix for discrepancies in reported Smart Block numbers Fix for discrepancies in reported Smart Block numbers (GH-952) Apr 18, 2018
@zarembsky zarembsky requested a review from jsignanini Apr 18, 2018
@jsignanini
jsignanini approved these changes Apr 23, 2018
View changes
@jsignanini
Merge branch 'develop' into feature/gh-952
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
38dd5e3
@jsignanini
Copy link
Member

@jsignanini jsignanini commented Apr 23, 2018

@zarembsky please take a look at the CI checks that failed
@trickpattyFH20 trickpattyFH20 mentioned this pull request Apr 23, 2018
Merged
@jsignanini
Merge branch 'develop' into feature/gh-952
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
d6e530e
@jsignanini jsignanini merged commit f9f2680 into develop Apr 23, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jsignanini jsignanini deleted the feature/gh-952 branch Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignanini jsignanini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@zarembsky @jsignanini