Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/gh 1677/shorten russian translations #400

Merged
merged 2 commits into from Jun 21, 2019
Merged

Bugfix/gh 1677/shorten russian translations #400

merged 2 commits into from Jun 21, 2019

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Jun 21, 2019

Shorten Russian translations for the Cliqz anti-tracking and adblock feature icon labels so that they fit in the available space without being dot dot dotted.

Tweak Summary view container spacing to be more resistant to locale-string-length-difference-caused layout breakage.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
wlycdgr added 2 commits Jun 20, 2019
@wlycdgr
Shorten Cliqz feature name Russian translations. Adjust line height f…
Loading status checks…
a3c9710 
…or feature name element to shift it up
@wlycdgr
Adjust summary view container spacing so it looks ok whether page sta…
Loading status checks…
f00295a 
…ts take up one or two lines
@wlycdgr wlycdgr requested a review from ghostery/ghostery as a code owner Jun 21, 2019
@wlycdgr wlycdgr requested a review from christophertino Jun 21, 2019
@christophertino
christophertino approved these changes Jun 21, 2019
View changes
@christophertino christophertino merged commit a6b27ca into develop Jun 21, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the bugfix/GH-1677/shorten-russian-translations branch Jun 21, 2019
@christophertino christophertino added this to the 8.4.0 milestone Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.4.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@wlycdgr @christophertino