Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix layout in Summary condensed view on Page Not Scanned pages #404

Merged
merged 2 commits into from Jul 2, 2019
Merged

Fix layout in Summary condensed view on Page Not Scanned pages #404

merged 2 commits into from Jul 2, 2019

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Jun 27, 2019

Also removes a redundant conditioanl check in Summary#render

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@wlycdgr
Fix layout in Summary condensed view on Page Not Scanned pages
Loading status checks…
5a6a508
@wlycdgr wlycdgr requested a review from ghostery/ghostery as a code owner Jun 27, 2019
@wlycdgr wlycdgr requested review from christophertino and jsignanini Jun 27, 2019
@christophertino christophertino added this to the 8.4.1 milestone Jul 2, 2019
@christophertino
Merge branch 'develop' into bugfix/GH-1778
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
3706d31
@christophertino
christophertino approved these changes Jul 2, 2019
View changes
@christophertino christophertino merged commit 22236a6 into develop Jul 2, 2019
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@christophertino christophertino deleted the bugfix/GH-1778 branch Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@jsignanini jsignanini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.4.1
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@wlycdgr @christophertino