ghostery / ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NPM Dependencies #405

Merged

christophertino merged 5 commits into develop from feature/update_packages

Jul 2, 2019

Member

christophertino commented Jun 27, 2019

This PR updates all npm packages and makes the following changes:

webpack refactor (add eslint-loader)
replace .eslintrc.json with eslintrc.js
replace .babelrc with babel.config.js
build Cliqz content-script-bundle.js from browser-core
fix ESLint errors due to updated lint rules

christophertino added 2 commits


            update npm dependencies. refactor webpack, babel, eslint

a3ac89b


            apply new eslint rules and fix errors

2ee1a30

christophertino requested a review from wlycdgr

christophertino requested review from IAmThePan, jsignanini, trickpattyFH20, zarembsky and ghostery/ghostery as code owners

remusao reviewed

app/content-scripts/content_script_bundle.js Show resolved Hide resolved

jsignanini reviewed

app/panel-android/components/content/Accordion.jsx Show resolved Hide resolved

jsignanini reviewed

app/panel-android/components/content/Accordion.jsx Show resolved Hide resolved

jsignanini reviewed

app/panel-android/components/content/TrackersChart.jsx Show resolved Hide resolved

jsignanini reviewed

app/panel/components/Blocking/BlockingHeader.jsx Show resolved Hide resolved

jsignanini reviewed

app/panel/components/Blocking/Tracker.jsx Show resolved Hide resolved

jsignanini reviewed

app/panel/components/Settings.jsx Show resolved Hide resolved

jsignanini reviewed

src/background.js Outdated Show resolved Hide resolved

jsignanini requested changes

Member

jsignanini left a comment

@christophertino left a few comments. The ones regarding replacing {' '} with   I marked a few but there a quite a lot more so I just stopped marking them; easier to do just do a find/replace.

christophertino added 3 commits


            fix formatting of if statements after lint auto-fix

7f6e42e


            fix proptype errors in hub

eaa2a1a


            update codeowners and readme

37339e8

christophertino removed the request for review from trickpattyFH20

Member Author

christophertino commented Jul 1, 2019

@jsignanini Changes made, please have a look

jsignanini approved these changes

christophertino merged commit e70fcd7 into develop

2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed

Details

continuous-integration/travis-ci/push The Travis CI build passed

Details

christophertino deleted the feature/update_packages branch

christophertino mentioned this pull request

Removed Duplicate Property #403

Closed

christophertino added this to the 8.4.1 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment