GH-1623: Update Hover State for Expanded View #408
Merged
Conversation
Contributor
tdtnguyen
commented
Jul 2, 2019
|
|
I left one comment but otherwise everything looks good! |
| top: 215px; | ||
| z-index: 3; | ||
| cursor: pointer; | ||
| background-position: center; |
IAmThePan
Jul 2, 2019
Contributor
Try using this to move the left caret to the left:
background-position: calc(50% - 1.75px);
you may have to have separate css selector for the right arrow and left.
Try using this to move the left caret to the left:
background-position: calc(50% - 1.75px);
you may have to have separate css selector for the right arrow and left.
|
I think it looks good but could be slightly better by moving the arrow by another pixel. Run this past Vinny tomorrow and once you get sign off by design I will merge the Pull Request. |
app/scss/partials/_detail.scss
Outdated
| @@ -97,11 +97,13 @@ | |||
| background-repeat: no-repeat; | |||
| background-image: url('../../app/images/panel/line.svg'); | |||
| &:hover { | |||
| background-position: calc(50% - 1.75px); | |||
IAmThePan
Jul 8, 2019
Contributor
I think this looks better with:
background-position: calc(50% - 2px);
I think this looks better with:
background-position: calc(50% - 2px);
|
Approved. Waiting to merge until we get the OK from Tino. |
tdtnguyen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.