Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1623: Update Hover State for Expanded View #408

Merged
merged 5 commits into from Jul 17, 2019
+30 −15
Merged

GH-1623: Update Hover State for Expanded View #408

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d7683fe
updated expanded view hover state
tdtnguyen Jul 2, 2019
92ee0cc
centered left caret
tdtnguyen Jul 2, 2019
4bc98db
adjusted caret spacing
tdtnguyen Jul 8, 2019
d701080
Merge branch 'develop' into expandedViewHoverState
IAmThePan Jul 9, 2019
3e956d0
Merge branch 'develop' into expandedViewHoverState
christophertino Jul 17, 2019
File filter
Filter file types
Clear filters
Jump to
Jump to file
Failed to load files.

Always

Just for now

Prev Next
Loading status checks…
centered left caret
  • Loading branch information
@tdtnguyen
tdtnguyen committed Jul 2, 2019
commit 92ee0ccf9401eb6655e5faae3e0e49bab9d28ddc
2 app/scss/partials/_detail.scss
View file
Open in desktop
@@ -97,11 +97,13 @@
background-repeat: no-repeat;
background-image: url('../../app/images/panel/line.svg');
&:hover {
background-position: calc(50% - 1.75px);

This comment has been minimized.

Sign in to view
@IAmThePan

IAmThePan Jul 8, 2019
Contributor

I think this looks better with:

background-position: calc(50% - 2px);
background-color: $ghosty-blue;
background-size: 7px 20px;
background-image: url('../../app/images/panel/caret-left.svg');
}
&.condensed:hover {
background-position: center;
This conversation was marked as resolved by IAmThePan

This comment has been minimized.

Sign in to view
@IAmThePan

IAmThePan Jul 8, 2019
Contributor

I think this looks better with:

background-position: calc(50% - 1px);
background-image: url('../../app/images/panel/caret-right.svg');
}
}
ProTip! Use n and p to navigate between commits in a pull request.