Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cliqz-url-parser for URL processing. #410
Use cliqz-url-parser for URL processing. #410
Changes from 1 commit
6044117b1628e7a64f3330e393b8File filter
Jump to
Use cliqz-url-parser for URL processing.
Unverified
sammacbethJul 5, 2019
Author
Contributor
This was carried over as-is from the previous version, but I wonder if it intentional that you use
hosthere instead ofhostname. The former includes the port number if it is non-standard. Are there patterns that use this information? If not, we could usehostnamehere to be more consistent. @christophertinojsignaniniJul 11, 2019
Member
I think that since we were creating a somewhat custom object being returned from
processUrl(), and not aiming to exactly replicate theURL()function, we just named ithostfor convenience but I agree that it could lead to confusion.