Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gh 1733/legal updates #414

Merged
merged 17 commits into from Jul 18, 2019
Merged

Feature/gh 1733/legal updates #414

merged 17 commits into from Jul 18, 2019

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Jul 17, 2019

Adds a yes-required, opt-in legal consent checkbox to the Hub and Extension account creation forms.

Hub form: 'Create Account' in the sidebar
Extension form: Hamburger menu -> 'Sign In' -> 'Create Account'

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
wlycdgr added 15 commits Jul 1, 2019
…used by dangerouslySetInnerHTML
…ecked. Implement red text error state.
…holder checkbox jsx to hub account creation view.
…dd and pass through checkbox state bool.
@wlycdgr wlycdgr requested review from IAmThePan and ghostery/ghostery as code owners Jul 17, 2019
@wlycdgr wlycdgr requested review from christophertino and jsignanini Jul 17, 2019
@christophertino christophertino added this to the 8.4.1 milestone Jul 17, 2019
@jsignanini jsignanini merged commit a0af14f into develop Jul 18, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jsignanini jsignanini deleted the feature/GH-1733/legal-updates branch Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants