Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1795: Expand Icon Showing over Tooltip #415

Merged
merged 2 commits into from Jul 19, 2019
Merged

GH-1795: Expand Icon Showing over Tooltip #415

merged 2 commits into from Jul 19, 2019

Conversation

@tdtnguyen
Copy link
Contributor

@tdtnguyen tdtnguyen commented Jul 18, 2019

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@tdtnguyen
increased tooltip z-index
Loading status checks…
2ac0141
@tdtnguyen tdtnguyen requested review from IAmThePan, jsignanini, zarembsky and ghostery/ghostery as code owners Jul 18, 2019
@tdtnguyen tdtnguyen closed this Jul 18, 2019
@tdtnguyen tdtnguyen reopened this Jul 18, 2019
@christophertino christophertino changed the base branch from master to develop Jul 18, 2019
@Eden12345
Eden12345 suggested changes Jul 18, 2019
View changes
app/scss/partials/_tooltip.scss Outdated Show resolved Hide resolved
@tdtnguyen
adjusted indices to suggestions
Loading status checks…
93e741b
@tdtnguyen tdtnguyen requested a review from Eden12345 Jul 18, 2019
@Eden12345
Eden12345 approved these changes Jul 18, 2019
View changes
@christophertino christophertino added this to the 8.4.1 milestone Jul 19, 2019
@christophertino christophertino merged commit c109f9f into develop Jul 19, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the gh-1795 branch Jul 19, 2019
@tdtnguyen tdtnguyen changed the title GH-1795: Expand Icon showing over Tooltip GH-1795: Expand Icon Showing Over Tooltip Jul 19, 2019
@tdtnguyen tdtnguyen changed the title GH-1795: Expand Icon Showing Over Tooltip GH-1795: Expand Icon Showing over Tooltip Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eden12345 Eden12345

@IAmThePan IAmThePan

@jsignanini jsignanini

@zarembsky zarembsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.4.1
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@tdtnguyen @Eden12345 @christophertino