Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1795: Expand Icon Showing over Tooltip #415

Merged
merged 2 commits into from Jul 19, 2019
+2 −2
Merged

GH-1795: Expand Icon Showing over Tooltip #415

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ac0141
increased tooltip z-index
tdtnguyen Jul 18, 2019
93e741b
adjusted indices to suggestions
tdtnguyen Jul 18, 2019
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Next
Loading status checks…
increased tooltip z-index
  • Loading branch information
@tdtnguyen
tdtnguyen committed Jul 18, 2019
commit 2ac01411063537bee98b4f6127720453fb07dcc0
2 app/scss/partials/_tooltip.scss
View file
Open in desktop
@@ -23,7 +23,7 @@
background-color: $mystic;
text-align: center;
position: absolute;
z-index: 3;
z-index: 100;
This conversation was marked as resolved by tdtnguyen

This comment has been minimized.

Sign in to view
@Eden12345

Eden12345 Jul 18, 2019 •
edited
Contributor

You can check with @vincentlai88 if you'd like, but I'm pretty sure he would want the toast messages to show up in front of tooltips (should that scenario arise).

The current z-index for the callout class (which controls the styling associated with the toast messages in the <Panel /> and <Settings /> components) is 5, which would make it appear behind the tooltip depending on the DOM organization. Please make ensure this doesn't happen by increasing the callout class's z-index property to be higher than the tooltip's z-index property.

Furthermore, all of the z-indices in this project are relatively low, with the exception of a couple outliers. I think it would be a good idea to continue with that pattern, and would suggest a z-index of 20 for the tooltip, and z-index of 30 for the callout class.
box-shadow: 0px 2px 2px 0 rgba(0, 0, 0, 0.2);
box-sizing: border-box;
&:after {
ProTip! Use n and p to navigate between commits in a pull request.