GH-1621: Site-Specific Whitelisting for Unknown Trackers via Anti-Tracking #417
Conversation
… on further commits until Design is finished reviewing the feature (a console.log has been added in each place where logic may be added to match upcoming feature implementation requirements)
…use tracker total for Donut Graph
|
@Eden12345 looks like opening the Settings view from the Panel is broken (shows blank). See the error logs in the panel's console log. |
| blocked: false, | ||
| catId: 'anti_tracking_unknown', | ||
| description: '', | ||
| id: 100000000 + idx, |
Eden12345
Jul 23, 2019
Author
Contributor
Remove this line along with any other props that are unnecessary for the <Tracker /> component for Unknown trackers
Remove this line along with any other props that are unnecessary for the <Tracker /> component for Unknown trackers
Eden12345
Jul 23, 2019
Author
Contributor
Edit: We still need a unique ID for this because it's used later as a React key prop when rendering all the trackers from the <Trackers /> component. I'll use the unknownTracker.name and concatenate it with the first domain listed in the unknownTracker.domains array (if the array is empty, it will just concatenate "undefined" onto the string).
Edit: We still need a unique ID for this because it's used later as a React key prop when rendering all the trackers from the <Trackers /> component. I'll use the unknownTracker.name and concatenate it with the first domain listed in the unknownTracker.domains array (if the array is empty, it will just concatenate "undefined" onto the string).
…ccasional bug with unwhitelisting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
JIRA Ticket: https://cliqztix.atlassian.net/browse/GH-1621
Notes
If you need more test cases, turn off Ad-Blocking and head to any news site like cnn.com
The race condition issue should be fixed along with a few other issues that @IAmThePan found, and I also have moved the strings into the translation library. It should be good to go at this point