Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh 1763/metrics feature/new triggers for broken page pings #418

Merged

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Jul 23, 2019

Watch for a range of user action sequences and report them to the metrics server as possibly indicative of a broken page, with the goal of improving our understanding of which user action sequences are actually most indicative of a broken page.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
wlycdgr added 13 commits Jul 17, 2019
…ayed off switch for the watcher, and set it to trigger on site whitelist
…t listeners instead of relying on new ones
…er comes in before it fires
…mments to broken page Metrics methods
… that the difference for thresholds for metrics and smart block is intentional.
…ic or global unblock as well as on site-specific allow
@wlycdgr wlycdgr requested review from jsignanini, zarembsky and ghostery/ghostery as code owners Jul 23, 2019
@wlycdgr wlycdgr requested a review from christophertino Jul 23, 2019
src/background.js Outdated Show resolved Hide resolved
@christophertino christophertino added this to the 8.4.1 milestone Jul 23, 2019
…broken-page-pings
@jsignanini jsignanini merged commit 8c5cccc into develop Jul 24, 2019
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@jsignanini jsignanini deleted the GH-1763/metrics-feature/new-triggers-for-broken-page-pings branch Jul 24, 2019
@benstrumeyer benstrumeyer mentioned this pull request Sep 29, 2020
5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants