Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh 1763/metrics feature/new triggers for broken page pings #418

Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
4ecd3d0
Update broken ping reload threshhold to 60 seconds
wlycdgr Jul 17, 2019
9c74083
Merge branch 'develop' into GH-1763/metrics-feature/new-triggers-for-…
wlycdgr Jul 19, 2019
1ed578e
Add startPossibleBrokenPageTimer method to Metrics, implement the del…
wlycdgr Jul 22, 2019
99305fc
Implement metrics broken page trigger handler that uses existing even…
wlycdgr Jul 22, 2019
52e9a7a
Add setup_pth and setup_block parameters to broken_page ping
wlycdgr Jul 22, 2019
311b498
Clear and reset broken page watcher setTimeout handler if a new trigg…
wlycdgr Jul 22, 2019
dd1d215
Add pause Ghostery trigger for Metrics broken page watcher
wlycdgr Jul 22, 2019
49281a8
Add local tracker unblock trigger for Metrics broken page watcher.
wlycdgr Jul 22, 2019
5e5d996
Handle new tab creation for broken page watcher. Add documentation co…
wlycdgr Jul 23, 2019
f2c49ab
Remove broken page metrics ping call from TabInfo#create
wlycdgr Jul 23, 2019
0664aa5
Revert smart unblock threshold to 30 seconds. Add comments explaining…
wlycdgr Jul 23, 2019
28da0df
Trigger metrics broken page watcher on individual tracker site specif…
wlycdgr Jul 23, 2019
e7cd1bc
Pacify linter
wlycdgr Jul 23, 2019
e0076c1
Only set broken page watcher on whitelist add, not both add and remove
wlycdgr Jul 23, 2019
b9cf1ee
Change this.BROKEN_APGE_NEW_TAB value to a less mysterious 5. RIP Age…
wlycdgr Jul 23, 2019
81aa786
Merge branch 'develop' into GH-1763/metrics-feature/new-triggers-for-…
jsignanini Jul 24, 2019
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Add setup_pth and setup_block parameters to broken_page ping

  • Loading branch information
wlycdgr committed Jul 22, 2019
commit 52e9a7a0911772e4757dce281f1199771b6d16a4
@@ -42,8 +42,8 @@ class Metrics {
this.ping_set = new Set();
this._brokenPageWatcher = {
flag: false,
triggerId: null,
triggerTime: null,
triggerId: '',
triggerTime: '',
};
}

@@ -131,9 +131,8 @@ class Metrics {
_clearBrokenPageWatcher() {
this._brokenPageWatcher = Object.assign({}, {
flag: false,
triggerId: null,
triggerTime: null,
watcherOffSwitch: null
triggerId: '',
triggerTime: '',
});
}

@@ -361,6 +360,12 @@ class Metrics {
metrics_url +=
// Reward ID
`&rid=${encodeURIComponent(this._getRewardId().toString())}`;
} else if (type === 'broken_page' && this._brokenPageWatcher.flag) {
metrics_url +=
// What triggered the broken page ping?
`&setup_path=${encodeURIComponent(this._brokenPageWatcher.triggerId.toString())}` +
// How much time passed between the trigger and the page refresh / open in new tab?
`&setup_block=${encodeURIComponent((Date.now() - this._brokenPageWatcher.triggerTime).toString())}`;
}

return metrics_url;
ProTip! Use n and p to navigate between commits in a pull request.