Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1621 (fix): Pass empty Anti-Tracking data and whitelist, even if feature is turned off #422

Merged
merged 1 commit into from Jul 25, 2019
Merged
Changes from all commits
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

@@ -30,10 +30,15 @@ export function getCliqzAntiTrackingData(tabId, tabHostUrl) {
let totalUnsafeCount = 0;
let totalUnknownCount = 0;
let unknownTrackerCount = 0;
const unknownTrackers = [];
const whitelistedUrls = conf.anti_tracking_whitelist;
if (!conf.enable_anti_tracking || !antitracking.background) {
return {
totalUnsafeCount,
totalUnknownCount,
unknownTrackerCount,
unknownTrackers,
whitelistedUrls,
};
}

@@ -42,8 +47,6 @@ export function getCliqzAntiTrackingData(tabId, tabHostUrl) {
const bugsValues = Object.values(bugs);
const othersValues = Object.values(others);

const unknownTrackers = [];

for (const bug of bugsValues) {
totalUnsafeCount += bug.cookies + bug.fingerprints;
}
@@ -80,10 +83,10 @@ export function getCliqzAntiTrackingData(tabId, tabHostUrl) {

return {
totalUnsafeCount,
unknownTrackers,
unknownTrackerCount,
totalUnknownCount,
whitelistedUrls: conf.anti_tracking_whitelist,
unknownTrackerCount,
unknownTrackers,
whitelistedUrls,
};
}

ProTip! Use n and p to navigate between commits in a pull request.