Gh 1767/bugfix/target blank links crash opera #426
Merged
Conversation
…rk on Opera as well as in other browsers
…tion component. Use this component in About view to fix the broken-in-Opera links there
…account view in the panel so that the links work on Opera
…sentCheckboxLabel
…r the CreateAccount view
…ent to reduce duplication
|
I've integrated José's changes from #429 that improve the handling of i18n strings with embedded links, cleaned up duplication, and added doc headers. Ready for another look. |
|
@wlycdgr would also be nice if we could rename |
…d openFixedDestinationLinkInNewTab. Fix bug in I18nWithLink#componentDidMount.
…b.com:ghostery/ghostery-extension into GH-1767/bugfix/target-blank-links-crash-Opera
Renamed to handleClickOnNewTabLink |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes Opera crashes in Help, About, Subscribe, and CreateAccount views that resulted from Opera needing to open panel-to-tab links through chrome.tabs.create only (vs. a raw link).
Note that the implementation changes needed to fix the bug in CreateAccount mean that it was necessary to add new strings to messages.json.