ghostery / ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ghostery-rewards] New Opt-in for Ghostery #427

Closed

aleksandr-cliqz wants to merge 3 commits into ghostery:develop from aleksandr-cliqz:M20-51_new-rewards-optin

Contributor

aleksandr-cliqz commented Jul 26, 2019 •

edited

https://cliqztix.atlassian.net/browse/M20-51
@luciancor @christophertino

Have you followed the guidelines in CONTRIBUTING.md?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Have you added an explanation of what your changes do?
Does your submission pass tests?
Did you lint your code prior to submission?

Aleksandr Panin added 3 commits


            M20-51: new optin for ghostery rewards

abb4c14


            M20-51: by default show card instead of hot-dog

2324a21


            M20-51: fix eslint

e5af4fa

aleksandr-cliqz requested a review from ghostery/ghostery as a code owner

luciancor added the Needs: Discussion label

Contributor Author

aleksandr-cliqz commented Jul 26, 2019 •

edited

@christophertino
[WIP] please do not merge it
we need to discuss business-logic

aleksandr-cliqz closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment