Gh 1763/metrics feature/new triggers for broken page pings #430
Conversation
…broken-page-pings
…ayed off switch for the watcher, and set it to trigger on site whitelist
…t listeners instead of relying on new ones
…er comes in before it fires
…mments to broken page Metrics methods
… that the difference for thresholds for metrics and smart block is intentional.
…ic or global unblock as well as on site-specific allow
…broken-page-pings
…in Metrics#_resetBrokenPageWatcher
…broken-page-pings
christophertino
deleted the
GH-1763/metrics-feature/new-triggers-for-broken-page-pings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Implement new broken page metrics with the goal of better undertanding which sequences of user actions are most likely to signify a broken page. Details are availble in GH-1763.
Includes fixes for errors observed during initial testing, including the 'unsafe-eval' error, the "ping name 'broken-page' not found" error, and the "cannot destructure property 'timeoutId' of 'undefined' or 'null'" error.