Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh 1763/metrics feature/new triggers for broken page pings #430

Closed
wants to merge 20 commits into from
Closed

Gh 1763/metrics feature/new triggers for broken page pings #430

wants to merge 20 commits into from
+0 −0

Commits on Jul 17, 2019

  1. Update broken ping reload threshhold to 60 seconds

    @wlycdgr
    wlycdgr committed Jul 17, 2019
    4ecd3d0

Commits on Jul 19, 2019

  1. Merge branch 'develop' into GH-1763/metrics-feature/new-triggers-for-… 

    …broken-page-pings
    @wlycdgr
    wlycdgr committed Jul 19, 2019
    9c74083

Commits on Jul 22, 2019

  1. Add startPossibleBrokenPageTimer method to Metrics, implement the del… 

    …ayed off switch for the watcher, and set it to trigger on site whitelist
    @wlycdgr
    wlycdgr committed Jul 22, 2019
    1ed578e

  2. Implement metrics broken page trigger handler that uses existing even… 

    …t listeners instead of relying on new ones
    @wlycdgr
    wlycdgr committed Jul 22, 2019
    99305fc

  3. Add setup_pth and setup_block parameters to broken_page ping

    @wlycdgr
    wlycdgr committed Jul 22, 2019
    52e9a7a

  4. Clear and reset broken page watcher setTimeout handler if a new trigg… 

    …er comes in before it fires
    @wlycdgr
    wlycdgr committed Jul 22, 2019
    311b498

  5. Add pause Ghostery trigger for Metrics broken page watcher

    @wlycdgr
    wlycdgr committed Jul 22, 2019
    dd1d215

  6. Add local tracker unblock trigger for Metrics broken page watcher.

    @wlycdgr
    wlycdgr committed Jul 22, 2019
    49281a8

Commits on Jul 23, 2019

  1. Handle new tab creation for broken page watcher. Add documentation co… 

    …mments to broken page Metrics methods
    @wlycdgr
    wlycdgr committed Jul 23, 2019
    5e5d996

  2. Remove broken page metrics ping call from TabInfo#create

    @wlycdgr
    wlycdgr committed Jul 23, 2019
    f2c49ab

  3. Revert smart unblock threshold to 30 seconds. Add comments explaining… 

    … that the difference for thresholds for metrics and smart block is intentional.
    @wlycdgr
    wlycdgr committed Jul 23, 2019
    0664aa5

  4. Trigger metrics broken page watcher on individual tracker site specif… 

    …ic or global unblock as well as on site-specific allow
    @wlycdgr
    wlycdgr committed Jul 23, 2019
    28da0df

  5. Pacify linter

    @wlycdgr
    wlycdgr committed Jul 23, 2019
    e7cd1bc

  6. Only set broken page watcher on whitelist add, not both add and remove

    @wlycdgr
    wlycdgr committed Jul 23, 2019
    e0076c1

  7. Change this.BROKEN_APGE_NEW_TAB value to a less mysterious 5. RIP Age… 

    …nt Smart
    @wlycdgr
    wlycdgr committed Jul 23, 2019
    b9cf1ee

Commits on Jul 29, 2019

  1. Merge branch 'develop' into GH-1763/metrics-feature/new-triggers-for-… 

    …broken-page-pings
    @wlycdgr
    wlycdgr committed Jul 29, 2019
    0f5a592

  2. Correct timeout handler name in Metrics#_resetBrokenPageWatcher

    @wlycdgr
    wlycdgr committed Jul 29, 2019
    d286689

  3. Correct broken_page ping name in Metrics#handleBrokenPageTrigger

    @wlycdgr
    wlycdgr committed Jul 29, 2019
    aa76f53

  4. Bind setTimeout handler to Metrics instance in getActiveTab callback … 

    …in Metrics#_resetBrokenPageWatcher
    @wlycdgr
    wlycdgr committed Jul 29, 2019
    4e18aaa

  5. Merge branch 'develop' into GH-1763/metrics-feature/new-triggers-for-… 

    …broken-page-pings
    @christophertino
    christophertino committed Jul 29, 2019
    6634a9b